ros-industrial/abb_librws

ubuntu xenial: Invalid arguments to find_dependency

gavanderhoorn opened this issue · 5 comments

gavanderhoorn commented

When attempting to build an application which depends on abb_librws with CMake, the build is aborted with the following error:

CMake Error at /usr/share/cmake-3.5/Modules/CMakeFindDependencyMacro.cmake:45 (message):
  Invalid arguments to find_dependency
Call Stack (most recent call first):
  /home/user/ros_ws/devel/share/abb_librws/abb_librwsConfig.cmake:10 (find_dependency)
  CMakeLists.txt:39 (find_package)

This happens on an up-to-date Ubuntu Xenial, with CMake 3.5.1.

gavanderhoorn commented

It looks like the cause is this line:

abb_librws/cmake/abb_librwsConfig.cmake.in

Lines 9 to 10 in 58ad0d3

# Find dependencies
find_dependency(Poco 1.4.3 REQUIRED COMPONENTS Foundation Net Util XML)

CMake 3.5.1 does not support REQUIRED nor COMPONENTS in find_dependency(..).

gavanderhoorn commented

Not sure we can actually do anything about this, other than not using find_dependency(..) here.

gavanderhoorn commented

@jontje: we may want to introduce a dummy package into the CI setup which exercises the CMake infrastructure installed as part of the install(..) of abb_librws. That would've let us know about this problem before merging #69.

  • 👍1
jontje commented

Not sure we can actually do anything about this, other than not using find_dependency(..) here.

For example use find_package instead? Are there any pros/cons?

traversaro commented

Not sure we can actually do anything about this, other than not using find_dependency(..) here.

For example use find_package instead? Are there any pros/cons?

find_dependency just gives a fancier error message if a dep is not found, i.e. saying something similar to "abb_librws is not found because it was unable to find Poco" instead of just "Poco not found", so using find_package here is perfectly ok.

  • 👍1