ros2/common_interfaces

consider changing sensor_msgs/Joy buttons to use bools

tfoote opened this issue · 1 comments

This is a follwup to the pre Foxy Message API review

Buttons seem to be bools. Are there buttons which have different values? Will the bools make API easier? Will the bool reduce content on the wire?

https://github.com/ros2/common_interfaces/pull/86/files#r392501587

I confirmed that DualShock 2 and 3 both have pressure sensitive buttons. https://en.wikipedia.org/wiki/DualShock

Most of them were removed in Dualshock 4 but not all https://gizbuyerguide.com/are-playstation-4-buttons-pressure-sensitive/

Since we have positive examples we shouldn't remove the ability to support pressure sensitive buttons.