`ros2 launch` bug for `$OVERRIDE_LAUNCH_PROCESS_OUTPUT`

[cfveeden]

Bug report

Required Info:

• Operating System:
  • 20.04
• Installation type:
  • Source
• Version or commit hash:
  • Galactic and Humble
• DDS implementation:
  • rmw_cyclonedds_cpp
• Client library:
  • N/A

Steps to reproduce issue

export ROS_LOG_DIR=~/.ros2/reproduce/
export OVERRIDE_LAUNCH_PROCESS_OUTPUT=screen
ros2 launch your_package your_launch.xml # launch anything that logs

Expected behavior

The launch specific logging messages should only be output to the screen and should not be written to launch.log.

Actual behavior

Irrespective of $OVERRIDE_LAUNCH_PROCESS_OUTPUT's value, launch specific logs get written to $ROS_LOG_DIR/*/launch.log.

Additional information

Additionally, it would be good if users could disable launch specific logging entirely since this option is not provided at the moment.