rseng/rse-phenotype

Plot does not scale back up after the axis scales down

bjoyce3 opened this issue · 9 comments

Suspected Usage/expected behavoir:

  • Each group should have a total of 100% across all dimensions
  • The plot axis automagically resizes as you scale down. That seems to reinforce the idea that everything should add to 100%

How to recreate:

  • scale each group dot down to 20 or 30%
  • try to scale back up to 40 or 50% and the line/dot will stop at the scaled down value

Possible fix:

  • Good question really. Allow percentages to be input into boxes in key:value pairs for all groups/dimensions somewhere on the page?
  • That seems kind of busy for a web app

Screen Shot 2020-07-09 at 20 47 33 (2)

vsoch commented

That’s actually intentional, this isn’t supposed to be anything scientific, more like you can define yourself from 0 to 100 for as many dimensions as you please.

vsoch commented

As for the auto scale, just leave one at 100 for a quick fix. It’s 10pm here and I’m relaxing and this doesn’t seem urgent.

vsoch commented

Or... open a PR and offer a fix! Even better. :)

That's fair. However you can't scale back up once you've scaled down the axis. I'm guessing that's not intentional? That screenshot was taken while trying to make the 'firefighting' back up past 23. Sorry for being unclear!

Or... open a PR and offer a fix! Even better. :)

I'll attempt it! But you'll notice my software engineering skills on that graph are non-existent. That isn't a bug or by chance :)

As for the auto scale, just leave one at 100 for a quick fix. It’s 10pm here and I’m relaxing and this doesn’t seem urgent.

I'm so sorry, definitely not urgent at all!

vsoch commented

Transferred again! So I thought of a quick fix to not allow the auto-scaling, and it seemed to do the trick! I updated the PR. As for the values adding to 100 - is this absolutely necessary? I'd like to hear your thoughts. My thinking is that I can vary from 0 to 100 on a bunch of dimensions. For example, 80% of the work that I do is for open source, and maybe also 80% is for the academic community. I'm not sure that I could represent that limiting the values to sum to 100. Anyhoo, you should be able to test the same PR, #10, and it will address this issue too. And yes, I seriously can't go to sleep when I know there is something I can fix, ha!

The 100% is my limited thinking. I assumed 100% is 1 FTE or 40 hours a week. I'm pretty sure we all work more than that; this issue evidence included!

I assumed 100% because that's the traditional way that kind of figure works, but I'm totally in for letting folks put in more than 100%. My phenotype isn't limited to 100% because I spend a lot more hours outside "1.0 FTE" helping people and answering questions so that my team doesn't have to as much.

bjoyce3-rse-phenotype

vsoch commented

This is fixed with #10