Phenotyper line on graph stops at 5 dimensions
bjoyce3 opened this issue · 2 comments
I really like this tool, but I fear I've broken it.
You can create more than 5 dimensions, but the lines on the graph won't make more than 5 points. I believe from a small amount of testing I can confirm that the last dimensions in the list are the ones that don't get dots/lines created. In the attached screen shot the last two items in the list (Grants/Proposals and Firefighting) are the ones that also don't get dots to give a percentage.
Two potential fixes out of infinite potential fixes:
- don't let anyone put in more than 5 dimensions and thus the dots won't matter
- let people put in more than 5 dimensions but figure out why the dots/lines aren't generated (and generate them I suppose).
hey @bjoyce3! Thanks for reporting the issue - it's definitely a bug! I've transferred the issue to the repository here since this is where the code is served from. We definitely don't want to limit the number of dimensions that the user can define, so best to just fix the bug. I've done this in #10 if you would care to test, you should be able to clone the branch, and then start a local webserver. Eg.,
git clone -b fix/dimension-bug https://github.com/rseng/rse-phenotype
cd rse-phenotype
# open browser to port 9999
python -m http.server 9999 Let me know if that fixes it for you and I'll merge the PR.