IE 8 is not supported

[malibeg]

Code is not working with Internet Explorer 8.
IndexOf and for ... in array doesn't work.
http://stackoverflow.com/questions/5659591/javascript-arrays-in-ie-8-issue

[onepablo]

Yep, I started fiddling with this. I can't actually recall where I got the following code from, but it helps with the IndexOf issue.

// Deal with indexOf issue in <IE9
if (!Array.prototype.indexOf) {
    Array.prototype.indexOf = function(searchElement /*, fromIndex */ ) {
        "use strict";
        if (this == null) {
            throw new TypeError();
        }
        var t = Object(this);
        var len = t.length >>> 0;
        if (len === 0) {
            return -1;
        }
        var n = 0;
        if (arguments.length > 1) {
            n = Number(arguments[1]);
            if (n != n) { // shortcut for verifying if it's NaN
                n = 0;
            } else if (n != 0 && n != Infinity && n != -Infinity) {
                n = (n > 0 || -1) * Math.floor(Math.abs(n));
            }
        }
        if (n >= len) {
            return -1;
        }
        var k = n >= 0 ? n : Math.max(len - Math.abs(n), 0);
        for (; k < len; k++) {
            if (k in t && t[k] === searchElement) {
                return k;
            }
        }
        return -1;
    }
}

[markmacgillivray]

Hi, thanks. I have added the above indexOf prototype to jquery.facetview.js but I am lucky enough not to have to build stuff for IE8, and so I have no way to test it. Please let me know if it is still an issue. Will look into the for...in... problem now. May just rewrite without those simplified loops (not efficient anyway).

[markmacgillivray]

I have rewritten the jquery.facetview.js to use for (var i; i < x.length, i++ ) style wherever x is a list rather than a dict. Again, I do not actually have a windows machine to test this on, but if anyone can let me know this is still a problem and why, I will ad more fixes.

[onepablo]

Aaaaaargh! I run Win7 in a VirtualBox . It decided to do a Windows update
so now I've got IE9. So... will have to wait til I get home tonight.

On 8 March 2013 17:28, markmacgillivray notifications@github.com wrote:

I have rewritten the jquery.facetview.js to use for (var i; i < x.length,
i++ ) style wherever x is a list rather than a dict. Again, I do not
actually have a windows machine to test this on, but if anyone can let me
know this is still a problem and why, I will ad more fixes.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-14632243
.

[onepablo]

Hi Mark,

Using IETester, this now works in IE8. Not IE7, but there's no excuse to
be using that now anyway!

Thanks a lot for getting this fixed.

P.

On 11 March 2013 09:56, Paul Madley onepablo@gmail.com wrote:

Aaaaaargh! I run Win7 in a VirtualBox . It decided to do a Windows update
so now I've got IE9. So... will have to wait til I get home tonight.

On 8 March 2013 17:28, markmacgillivray notifications@github.com wrote:

I have rewritten the jquery.facetview.js to use for (var i; i < x.length,
i++ ) style wherever x is a list rather than a dict. Again, I do not
actually have a windows machine to test this on, but if anyone can let me
know this is still a problem and why, I will ad more fixes.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-14632243
.