struct socket in scclient.c rather than in scclient.h

Question

struct socket in scclient.c rather than in scclient.h

Closed this issue 7 years ago · 12 comments

Any specific reason on why struct socket is defined in scclient.c rather than (ideally) in scclient.h?

Answer 1 · 2018-02-15T10:07:00.000Z

I am going to change it, wanted to write code oops way, but need some refactoring on it.... Are you able to get disconnect event from the server?

…

On Feb 15, 2018 3:35 PM, "Cogmeta" ***@***.***> wrote: Any specific reason on why struct socket is defined in scclient.c rather than (ideally) in scclient.h? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP8vScI0pKLiyZKEOeGxid-0aeh19eCXks5tVAFmgaJpZM4SGmA0> .

Answer 2 · 2018-02-15T10:19:57.000Z

Yes, able to connect and send/receive messages. Also, getting disconnect event after server stop.

Answer 3 · 2018-02-15T10:21:52.000Z

./emitter
connecting...
[2018/02/15 10:19:03:8775] NOTICE: Initial logging level 7
[2018/02/15 10:19:03:8797] NOTICE: Libwebsockets version: 2.0.3 unknown-build-hash
[2018/02/15 10:19:03:8820] NOTICE: IPV6 not compiled in
[2018/02/15 10:19:03:8842] NOTICE: libev support compiled in but disabled
[2018/02/15 10:19:03:8863] NOTICE: libuv support compiled in but disabled
[2018/02/15 10:19:03:8896] NOTICE: Threads: 1 each 1024 fds
[2018/02/15 10:19:03:8898] NOTICE: mem: platform fd map: 4096 bytes
[2018/02/15 10:19:03:8900] NOTICE: Compiled with OpenSSL support
[2018/02/15 10:19:03:9232] NOTICE: Creating Vhost 'default' port -1, 1 protocols
[2018/02/15 10:19:03:9312] NOTICE: mem: per-conn: 600 bytes + protocol rx buf
[2018/02/15 10:19:03:9330] NOTICE: canonical_hostname = UNIT2
[Main] context created.
[Main] wsi create success.
[2018/02/15 10:19:03:9990] NOTICE: lws_protocol_init
[2018/02/15 10:19:12:8070] NOTICE: lws_context_destroy
successfully connected
Authentication is false
successfully dis-connected

Answer 4 · 2018-02-15T10:25:15.000Z

Thats great ✌️👍. Can you put your system specification in here. I usually go for Linux. It was creating problem for disconnect event.

…

On Feb 15, 2018 3:51 PM, "Cogmeta" ***@***.***> wrote: ./emitter connecting... [2018/02/15 10:19:03:8775] NOTICE: Initial logging level 7 [2018/02/15 10:19:03:8797] NOTICE: Libwebsockets version: 2.0.3 unknown-build-hash [2018/02/15 10:19:03:8820] NOTICE: IPV6 not compiled in [2018/02/15 10:19:03:8842] NOTICE: libev support compiled in but disabled [2018/02/15 10:19:03:8863] NOTICE: libuv support compiled in but disabled [2018/02/15 10:19:03:8896] NOTICE: Threads: 1 each 1024 fds [2018/02/15 10:19:03:8898] NOTICE: mem: platform fd map: 4096 bytes [2018/02/15 10:19:03:8900] NOTICE: Compiled with OpenSSL support [2018/02/15 10:19:03:9232] NOTICE: Creating Vhost 'default' port -1, 1 protocols [2018/02/15 10:19:03:9312] NOTICE: mem: per-conn: 600 bytes + protocol rx buf [2018/02/15 10:19:03:9330] NOTICE: canonical_hostname = UNIT2 [Main] context created. [Main] wsi create success. [2018/02/15 10:19:03:9990] NOTICE: lws_protocol_init [2018/02/15 10:19:12:8070] NOTICE: lws_context_destroy successfully connected Authentication is false successfully dis-connectedconnected. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP8vSSuqQCht6Js873mWrlp0BHEzr7wNks5tVAVAgaJpZM4SGmA0> .

Answer 5 · 2018-02-15T10:52:34.000Z

Will do. But, i need to rearrange the code urgently. we need to use multiple socketcluster services but currently this is not possible because of global socket variable *s. Is there a way to pass a context containing socket to ws_service_callback?

Answer 6 · 2018-02-15T10:54:24.000Z

Yeah you can create multiple sockets, need little code change though. Good thing you have figured out it's a global variable. Will change it in free time

…

On Feb 15, 2018 4:22 PM, "Cogmeta" ***@***.***> wrote: Will do. But, i need to rearrange the code urgently. we need to use multiple socketcluster services but currently this is not possible because of global socket variable *s. Is there a way to pass a context containing socket to ws_service_callback? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP8vSQwN4_WB6pbazPQQaQEbjqcIev49ks5tVAxzgaJpZM4SGmA0> .

Answer 7 · 2018-02-15T10:56:26.000Z

We will be happy to change it. Then, you can review it. But for now we need to figure out how to pass the socket to ws_service_callback. That is the only function where socket is needed. Any ideas?

Answer 8 · 2018-02-15T11:36:39.000Z

As good as this stuff is, unfortunately we will have to start from scratch using libwebsockets. We can not create a separate thread for every emit but will have to handle all the emits in one existing threads possibly by queuing messages.

Can you help us with issues that will arise specially with the initial handshake?

Answer 9 · 2018-02-15T17:30:21.000Z

Yeah I surely can :)

Answer 10 · 2018-02-16T08:33:28.000Z

Thanks @sacOO7 . For now, we ended up writing c++ client with Boost::Beast. It is extremely easy with inclusion of Beast in Boost starting 1.66.0. But, we would like to help you clean up c client as well when time permits. For now, I will close this one.

Answer 11 · 2018-02-16T19:52:45.000Z

Thank you @cogmeta. I am really grateful 👍

Answer 12 · 2018-02-18T15:57:30.000Z

Hi @cogmeta , if you feel to have any changes in library, Feel free to create a Pull Request. We are actively looking for potential contributors as good as you 👍. Thank you 👍