sagemath/sage

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 5: sage.graphs)

Closed this issue · 15 comments

mkoeppe commented

Follow-up from #29706 (which is NOT a dependency).

This ticket takes care of sage.graphs except for sage.graphs.graph_decompositions, which is done in #28925, and OptionalExtensions, which are done in #29720.

CC: @kliem @dcoudert @dimpase

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 5d5803e

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29790

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
 Follow-up from #29706.
 
-This ticket takes care of `sage.graphs` except for `sage.graphs.graph_decompositions`, which is done in #28925.
+This ticket takes care of `sage.graphs` except for `sage.graphs.graph_decompositions`, which is done in #28925, and `OptionalExtension`s, which are done in #29720.
mkoeppe commented

New commits:

55bd7basrc/module_list.py: Move options for Extensions in sage.graphs to distutils directives
mkoeppe commented

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-Follow-up from #29706.
+Follow-up from #29706 (which is NOT a dependency).
 
 This ticket takes care of `sage.graphs` except for `sage.graphs.graph_decompositions`, which is done in #28925, and `OptionalExtension`s, which are done in #29720.
mkoeppe commented

Commit: 55bd7ba

mkoeppe commented

Author: Matthias Koeppe

kliem commented

Reviewer: Jonathan Kliem

kliem commented
comment:4

LGTM.

mkoeppe commented
comment:5

Thanks!

mkoeppe commented
comment:6

https://github.com/mkoeppe/sage/runs/747836383

graphs   ] WARNING: autodoc: failed to import module 'planarity' from module 'sage.graphs'; the following exception was raised:
[graphs   ] dlopen(/Users/runner/runners/2.263.0/work/sage/sage/.tox/local-homebrew-macos-standard/local/lib/python3.7/site-packages/sage/graphs/planarity.cpython-37m-darwin.so, 2): Symbol not found: _gp_AddEdge
[graphs   ]   Referenced from: /Users/runner/runners/2.263.0/work/sage/sage/.tox/local-homebrew-macos-standard/local/lib/python3.7/site-packages/sage/graphs/planarity.cpython-37m-darwin.so
[graphs   ]   Expected in: flat namespace
sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

5d5803esrc/sage/graphs/planarity.pyx: Add forgotten distutils directive
sagetrac-git commented

Changed commit from 55bd7ba to 5d5803e

kliem commented
comment:9

Should be fine now.

mkoeppe commented
comment:10

Thanks!