sage.categories: Replace imports from sage.rings.all by more specific imports
Closed this issue · 14 comments
sage.rings.all has a mixture of generic classes and implementation classes. Some of the generic and/or basic ones will probably have to be included in sage-objects (#29865). We prepare this by getting rid of imports from sage.rings.all throughout sage.categories.
CC: @tscrim
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: 82676e6
Reviewer: Travis Scrimshaw, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/29881
I have also run into import loops in a subtle way because of stuff importing from rings.all. Strong +1 on doing this broadly. There might be a slight bit of care needed for lazily important objects, but I don't remember if this was an actual issue or how big this is.
Commit: 82676e6
Description changed:
---
+++
@@ -1,2 +1,2 @@
-`sage.rings.all` has a mixture of generic classes and implementation classes. Some of the generic ones will probably have to be included in `sage-objects` (#29865). We prepare this by getting rid of imports from `sage.rings.all` throughout `sage.categories`.
+`sage.rings.all` has a mixture of generic classes and implementation classes. Some of the generic and/or basic ones will probably have to be included in `sage-objects` (#29865). We prepare this by getting rid of imports from `sage.rings.all` throughout `sage.categories`.
Author: Matthias Koeppe
Reviewer: Travis Scrimshaw
Green patchbot => positive review.
bot is green
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton
Thanks!
Changed branch from u/mkoeppe/sage_categories__replace_imports_from_sage_rings_all_by_more_specific_imports to 82676e6