Remove sage.libs.readline
Closed this issue · 22 comments
Unused, should remove.
It was added 8 years ago, in #14523, but the Python world has moved away from using readline: IPython is using different libraries for terminal interaction now.
Component: interfaces
Author: Matthias Koeppe, Travis Scrimshaw
Branch/Commit: ed14848
Reviewer: Travis Scrimshaw, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/32073
Description changed:
---
+++
@@ -1,2 +1,4 @@
Unused, should remove.
+It was added 8 years ago, in #14523, but the Python world has moved away from using readline: IPython is using different libraries for terminal interaction now.
+I think it is already defunct because in normal Sage terminal interaction, readline is not used, so whatever this interface is offering (with interleaved_output()) can't work any more.
How about we just remove it immediately, without deprecation?
It's broken, no need for deprecation.
New commits:
c9e42ec | src/sage/libs/readline.pyx: Unused, remove; remove dependency of sagelib on readline |
Author: Matthias Koeppe
This won't break again #14289, correct? I don't have an OSX machine to verify this.
This module is unused. Try a search for imports of it
Thanks. Then I will now apply fire and holy water to it.
Reviewer: Travis Scrimshaw
Thanks!
Merge conflict
Branch pushed to git repo; I updated commit sha1. New commits:
8feca2a | Merge tag '9.4.beta5' into t/32073/deprecate_sage_libs_readline |
Documentation fails to build
Changed branch from u/mkoeppe/deprecate_sage_libs_readline to u/tscrim/deprecate_readline-32073
Removed the lib file from the reference manual. Doc builds for me.
New commits:
ed14848 | Remove readline lib file from the documentation. |
Changed author from Matthias Koeppe to Matthias Koeppe, Travis Scrimshaw
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Matthias Koeppe
Changed branch from u/tscrim/deprecate_readline-32073 to ed14848