sage.rings.fast_arith: Remove compile-time dependency on cypari2

Question

sage.rings.fast_arith: Remove compile-time dependency on cypari2

Closed this issue 4 years ago · 33 comments

mkoeppe commented 4 years ago

Follow-up on #30022

CC: @kliem @videlec @tscrim

Component: refactoring

Author: Jonathan Kliem

Branch/Commit: 41df930

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32441

Answer 1 · 2021-09-01T12:33:38.000Z

Author: Jonathan Kliem

Answer 2 · 2021-09-01T12:33:38.000Z

Dependencies: 30022

Answer 3 · 2021-09-01T12:33:38.000Z

Commit: e0c8466

Answer 4 · 2021-09-01T12:33:38.000Z

New commits:

`a8a9437`	`pull in from #30022 to avoid merge conflict`
`e0c8466`	`remove pari compile time dependency from rings.fast_arith`

Answer 5 · 2021-09-01T12:33:38.000Z

Branch: public/32441

Answer 6 · 2021-09-01T12:33:47.000Z

Changed dependencies from 30022 to #30022

Answer 7 · 2021-09-01T12:35:56.000Z

Changed commit from e0c8466 to cbfec03

Answer 8 · 2021-09-01T12:35:56.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`cbfec03`	`fix function signatures`

Answer 9 · 2021-09-02T10:38:57.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`cfcf047`	`add doctests that confirms that cysignals interfaces the PARI signals`
`d422435`	`updated checksums`

Answer 10 · 2021-09-02T10:38:57.000Z

Changed commit from cbfec03 to d422435

Answer 11 · 2021-09-02T18:43:15.000Z

comment:5

wrong ticket?

Answer 12 · 2021-09-02T19:33:27.000Z

Changed commit from d422435 to cbfec03

Answer 13 · 2021-09-02T19:33:27.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

Answer 14 · 2021-09-02T19:35:07.000Z

comment:7

Replying to @mkoeppe:

wrong ticket?

Thanks. I was confused why the checksum for #32431 were incorrect. That explains it.

I thought I had done #32441 from a different computer, but I guess I was in remote shell. Didn't catch on at that time.

Answer 15 · 2021-09-03T07:36:59.000Z

comment:8

Also I think commit a8a9437 needs to be dropped

Answer 16 · 2021-09-03T07:43:57.000Z

comment:10

Replying to @mkoeppe:

Also I think commit a8a9437 needs to be dropped

This was on purpose. I accidently already commit fast_arith.pyx. But this is mostly to avoid merge conflicts in convert_sage.pyx, because both tickets append to that file. This will not work.

Answer 17 · 2021-09-03T07:45:17.000Z

comment:11

Hence the dependency on #30022.

Answer 18 · 2021-09-03T08:01:02.000Z

comment:13

I don't get it; can you not just rebase onto the branch of #30022, i.e., b4477da?

Answer 19 · 2021-09-03T08:36:55.000Z

Changed branch from public/32441 to public/32441-reb

Answer 20 · 2021-09-03T08:36:55.000Z

New commits:

`08084b3`	`sage.libs.pari.convert_sage: Move set_integer_from_gen here from sage.rings.integer (set_from_pari_gen)`
`9986723`	`remove compile time dependency of Integer and Rational on cypari2`
`c08a8b5`	`remove compile-time dependency on flint from integer`
`88d91ba`	`use try ... except ... else`
`b4477da`	`fixed indent`
`6ae2006`	`Merge branch 'develop' of git://trac.sagemath.org/sage into public/32441-reb`
`1aa8cd1`	`pull in from #30022 to avoid merge conflict`
`05bb421`	`remove pari compile time dependency from rings.fast_arith`

Answer 21 · 2021-09-03T08:36:55.000Z

Changed commit from cbfec03 to 05bb421

Answer 22 · 2021-09-03T08:39:32.000Z

comment:15

Replying to @mkoeppe:

I don't get it; can you not just rebase onto the branch of #30022, i.e., b4477da?

Indeed, it doesn't work. I tried to pull in only those files, but git couldn't even get it to work and I still had merge conflicts.

Answer 23 · 2021-09-03T08:42:20.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0087de5`	`fix function signatures`

Answer 24 · 2021-09-03T08:42:20.000Z

Changed commit from 05bb421 to 0087de5

Answer 25 · 2021-09-13T23:35:24.000Z

comment:17

9.5.beta1 is out... rebase?

Answer 26 · 2021-09-14T06:55:55.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1c11285`	`Merge branch 'public/32441-reb' of git://trac.sagemath.org/sage into public/32441-reb2`

Answer 27 · 2021-09-14T06:55:55.000Z

Changed commit from 0087de5 to 1c11285

Answer 28 · 2021-09-14T06:57:29.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`cbbef63`	`pull in from #30022 to avoid merge conflict`
`2c46a20`	`remove pari compile time dependency from rings.fast_arith`
`41df930`	`fix function signatures`

Answer 29 · 2021-09-14T06:57:29.000Z

Changed commit from 1c11285 to 41df930

Answer 30 · 2021-09-14T07:03:44.000Z

Changed dependencies from #30022 to none

Answer 31 · 2021-09-19T05:24:28.000Z

Reviewer: Matthias Koeppe

Answer 32 · 2021-09-20T06:53:19.000Z

comment:22

Thank you.

Answer 33 · 2021-09-25T23:18:09.000Z

Changed branch from public/32441-reb to 41df930