Clear out init.py in sage.rings.polynomial

Question

Clear out init.py in sage.rings.polynomial

Closed this issue 4 years ago · 8 comments

sage.rings.polynomial (and all of sage.rings) has lots of Cython modules that depend on various C/C++ libraries and will have to go into different distribution packages (#29705, #32501).

Thus we need to clear out __init__.py, which currently contains a workaround added in #25848 ("Some preparations for binding=True") in preparation for #22747/#26254. As this effort has stalled, we remove this workaround; a new solution can be found when #26254 gains traction again.

CC: @fchapoton @tscrim @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: c41e11c

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/32509

Answer 1 · 2021-09-13T19:37:22.000Z

Branch: u/mkoeppe/clear_out___init___py_in_sage_rings_polynomial

Answer 2 · 2021-09-13T19:37:35.000Z

Author: Matthias Koeppe

Answer 3 · 2021-09-13T19:37:35.000Z

Commit: c41e11c

Answer 4 · 2021-09-13T19:37:35.000Z

New commits:

`c41e11c`	`src/sage/rings/polynomial/__init__.py: Remove cyclic-import workaround, not needed currently`

Answer 5 · 2021-09-18T09:38:40.000Z

Reviewer: Marc Mezzarobba

Answer 6 · 2021-09-18T09:38:40.000Z

comment:3

Looks like a trivial change that won't hurt.

Answer 7 · 2021-09-18T16:17:44.000Z

comment:4

Thanks.

Answer 8 · 2021-09-25T23:18:00.000Z

Changed branch from u/mkoeppe/clear_out___init___py_in_sage_rings_polynomial to c41e11c