Modularization changes in sage.modules, sage.matrix

[mkoeppe]

cherry-picked from #32432

Depends on #32637
Depends on #32665

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 8679256

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32725

[mkoeppe]

Branch: u/mkoeppe/modularization_changes_in_sage_modules__sage_matrix

[mkoeppe]

Commit: 69e8968

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+cherry-picked from #32432

[mkoeppe]

Dependencies: #32637, #32665

[mkoeppe]

Last 10 new commits:

50c5f58	src/sage/matrix/args.pyx: Move import of RDF, CDF into method
d081814	src/sage/matrix/matrix_misc.py: Move import of PolynomialRing into method
561bad4	sage.modules, sage.matrix: Use sage.rings.abc more
e072aa1	sage.structure, sage.rings, sage.matrix: Use sage.rings.abc for IntegerModRing
b349740	src/sage/modules/free_module.py: Use sage.rings.abc.Order
f2f00e5	src/sage/matrix/matrix_space.py: More try..except for imports
40f01d5	src/sage/modules/free_module.py: More try..except for imports
65a5ce3	src/sage/modules/free_module_element.pyx: Do not fail if numpy cannot be imported
b325232	Matrix.gram_schmidt: Use sage.rings.abc
69e8968	Matrix.gram_schmidt: Use sage.rings.abc (fixup)

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

comment:3

I don't think the doctest failure in src/sage/rings/integer.pyx is coming from this ticket

[kliem]

Reviewer: Jonathan Kliem

[kliem]

comment:5

• There is a missing empty-line before this one.

+    if is_sparse:
+        return free_module_element.FreeModuleElement_generic_sparse

It is really different from the above, as it also catches some of the above cases, where an import failed.

• If you are touching this line, you might as well fix it (Returns -> Return):

+    Returns True if ``R`` is the symbolic expression ring.

Once done, you can put it on positive review on my behalf.

[sagetrac-git]

Changed commit from 69e8968 to b85aaa4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

810e3e6	src/sage/modules/free_module.py: Separate long if/elif chain from the following code by a newline
b85aaa4	src/sage/symbolic/ring.pyx: Returns -> Return in docstring

[mkoeppe]

comment:7

Thanks for reviewing!

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

8679256

Merge tag '9.5.beta5' into t/32725/modularization_changes_in_sage_modules__sage_matrix

[sagetrac-git]

Changed commit from b85aaa4 to 8679256

[mkoeppe]

comment:9

Merged new beta.

[vbraun]

Changed branch from u/mkoeppe/modularization_changes_in_sage_modules__sage_matrix to 8679256