sage.rings.abc: Add pAdicRing, pAdicField; deprecate is_pAdic...

`1893620`	`src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Use sage.rings.abc.pAdicRing, pAdicField`
`8422015`	`src/sage/modular/overconvergent/genus0.py: Use sage.rings.abc.pAdicField`
`c32b3a2`	`src/sage/schemes/berkovich: Use sage.rings.abc.pAdicField`
`96a778b`	`src/sage/schemes/elliptic_curves/constructor.py: Use sage.rings.abc.pAdicField`
`b672836`	`src/sage/schemes/hyperelliptic_curves: Use sage.rings.abc.pAdicField`
`e1412c7`	`src/sage/schemes/projective/projective_morphism.py: Use sage.rings.abc.pAdicField`

Answer 4 · 2021-10-24T02:23:43.000Z

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
-This change will allow use to eliminate the imports from `sage.rings.padics` in `sage.rings.polynomial.polynomial_element`
+This change will allow use to eliminate imports from `sage.rings.padics` in `sage.rings.polynomial.polynomial_element`.
 
+Part of Meta-ticket #32414.
+

Answer 5 · 2021-10-24T02:23:43.000Z

Author: Matthias Koeppe

Answer 6 · 2021-10-24T02:28:10.000Z

Changed commit from e1412c7 to fc7025a

Answer 7 · 2021-10-24T02:28:10.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fc7025a`	`src/sage/rings/padics/generic_nodes.py: Update doctests with deprecation warning output`

Answer 8 · 2021-10-24T02:32:59.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`070d05b`	`src/sage/schemes/projective/projective_morphism.py: Avoid merge conflict`

Answer 9 · 2021-10-24T02:32:59.000Z

Changed commit from fc7025a to 070d05b

Answer 10 · 2021-10-24T19:07:51.000Z

Changed branch from u/mkoeppe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___ to u/gh-EnderWannabe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___

Answer 11 · 2021-10-24T19:09:47.000Z

Changed commit from 070d05b to 59271be

Answer 12 · 2021-10-24T19:09:47.000Z

comment:7

Added missing imports in src/sage/modular/overconvergent/genus0.py and src/sage/schemes/hyperelliptic_curves/constructor.py. Hopefully this passes patchbot now; the rest of the changes looked good to me.

New commits:

`59271be`	`32750: added missing imports`

Answer 13 · 2021-10-24T19:27:35.000Z

comment:8

Thanks for fixing this!

Answer 14 · 2021-10-24T21:51:13.000Z

comment:9

The remaining failure, from src/sage/rings/integer.pyx, is not from this ticket. It is fixed in #32737.

Answer 15 · 2021-10-25T08:24:19.000Z

comment:10

pyflakes detects that the import from sage.rings.ring import EuclideanDomain, Field in generic_nodes.py can probably be removed now.

Answer 16 · 2021-10-25T15:32:18.000Z

Changed branch from u/gh-EnderWannabe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___ to u/mkoeppe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___

Answer 17 · 2021-10-25T19:09:34.000Z

Changed commit from 59271be to 0a1b9ac

Answer 18 · 2021-10-25T19:09:34.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`59271be`	`32750: added missing imports`
`0a1b9ac`	`src/sage/rings/padics/generic_nodes.py: Remove unused imports`

Answer 19 · 2021-10-25T19:09:58.000Z

comment:13

Rebased on top of gh-EnderWannabe's fixes.

Answer 20 · 2021-10-25T19:43:24.000Z

Changed commit from 0a1b9ac to c46eb46

Answer 21 · 2021-10-25T19:43:24.000Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`b484d51`	`src/sage/symbolic/callable.py: Fixup`
`fad87c0`	`Expression.is_callable: New`
`4bc059b`	`src/sage/ext/fast_callable.pyx: Remove use of is_CallableSymbolicExpression`
`8624925`	`src/sage/symbolic/ring.pyx: Update doctest output with deprecation warning`
`37da733`	`src/sage/sets/condition_set.py: Remove use of is_CallableSymbolicExpression`
`80a8f9e`	`sage.plot: Remove use of is_CallableSymbolicExpression, is_SymbolicEquation`
`a287531`	`src/sage/schemes/elliptic_curves/constructor.py: Remove use of SR, is_SymbolicEquation; add test for symbolic input`
`c9861d1`	`src/sage/interfaces/qepcad.py: Remove use of is_SymbolicEquation`
`341337a`	`src/sage/ext/fast_callable.pyx: Remove use of is_SymbolicVariable`
`c46eb46`	`Merge #32665`

Answer 22 · 2021-10-25T19:44:01.000Z

comment:15

Merged #32665 to resolve merge conflict.

Answer 23 · 2021-10-25T19:44:01.000Z

Dependencies: #32665

Answer 24 · 2021-10-26T07:31:34.000Z

comment:16

If we are touching this line anyway, we might as well add the second space before #:

+        elif isinstance(base, sage.rings.abc.pAdicField): # change base to Qpbar

Once done, you can put it on positive review on my behalf.

Answer 25 · 2021-10-26T07:31:34.000Z

Reviewer: Jonathan Kliem

Answer 26 · 2021-10-26T07:42:28.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`03b24bd`	`src/sage/schemes/berkovich/berkovich_space.py: Whitespace fix`

Answer 27 · 2021-10-26T07:42:28.000Z

Changed commit from c46eb46 to 03b24bd

Answer 28 · 2021-10-26T07:43:43.000Z

Changed author from Matthias Koeppe to Matthias Koeppe, Alexander Galarraga

Answer 29 · 2021-10-26T07:43:43.000Z

comment:18

Thank you!

Answer 30 · 2021-10-31T22:20:53.000Z

Changed branch from u/mkoeppe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___ to 03b24bd