sage.geometry: More # optional

Question

sage.geometry: More # optional

Closed this issue 4 years ago · 29 comments

mkoeppe commented 4 years ago

Depends on #32776
Depends on #32732
Depends on #32174
Depends on #32889

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1c028c7

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32846

Answer 1 · 2021-11-10T04:04:14.000Z

Dependencies: #32776

Answer 2 · 2021-11-10T04:06:35.000Z

Branch: u/mkoeppe/sage_geometry_polyhedron__more___optional

Answer 3 · 2021-11-10T04:44:12.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8085729`	`src/sage/geometry: Mark more doctests # optional - sage.rings.number_field`
`0c5ed4c`	`src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst: Add # optional - sage.rings.number_field, sage.symbolic`
`89267f8`	`src/sage/geometry/polyhedron/backend_normaliz.py: Add more # optional - sage.rings.number_field`
`ebe5d22`	`src/sage/geometry/polyhedron/base.py: Add more # optional - sage.rings.number_field`

Answer 4 · 2021-11-10T04:44:12.000Z

Commit: ebe5d22

Answer 5 · 2021-11-10T04:44:43.000Z

Author: Matthias Koeppe

Answer 6 · 2021-11-10T05:07:03.000Z

Changed dependencies from #32776 to #32776, #32732

Answer 7 · 2021-11-10T05:08:10.000Z

Changed commit from ebe5d22 to df22260

Answer 8 · 2021-11-10T05:08:10.000Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`f32b992`	`src/sage/features/sagemath.py (sage.combinat): Fix the name of the tested PythonModule`
`30eee2e`	`src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Add another missing # optional - sage.plot`
`c1b1d93`	`src/sage/geometry/polyhedron/plot.py: Add more # optional - sage.plot`
`eb31b22`	`src/sage/geometry/voronoi_diagram.py: Add # optional - sage.rings.number_field`
`d1b3bca`	`src/sage/geometry/integral_points.pyx: Add # optional - sage.rings.number_field`
`98522e0`	`src/sage/numerical: Add # optional - sage.rings.number_field`
`b846c0a`	`src/sage/numerical/backends/interactivelp_backend.pyx: Add missing # optional`
`94999bc`	`Merge #32732`
`a36005e`	`src/sage/geometry/polyhedron/parent.py: Add # optional - sage.rings.number_field`
`df22260`	`src/sage/geometry/polyhedron/library.py: Add # optional - sage.rings.number_field`

Answer 9 · 2021-11-10T05:32:29.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5d54e67`	`src/sage/geometry/polyhedron/base.py: Add more # optional - sage.graphs, sage.combinat, sage.rings.number_field`
`47c97cc`	`src/sage/geometry/polyhedron/base.py: Add # optional - sage.plot`

Answer 10 · 2021-11-10T05:32:29.000Z

Changed commit from df22260 to 47c97cc

Answer 11 · 2021-11-10T23:24:23.000Z

Changed commit from 47c97cc to 5e1df0d

Answer 12 · 2021-11-10T23:24:23.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`148dad2`	`src/sage/geometry/polyhedron/base.py: Add missing # optional - sage.rings.number_field`
`5e1df0d`	`src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst: Add missing # optional - sage.rings.number_field`

Answer 13 · 2021-11-12T23:22:56.000Z

Changed commit from 5e1df0d to 44f15a0

Answer 14 · 2021-11-12T23:22:56.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`44f15a0`	`Merge tag '9.5.beta6' into t/32846/sage_geometry_polyhedron__more___optional`

Answer 15 · 2021-11-16T05:25:35.000Z

Changed commit from 44f15a0 to 38ff15b

Answer 16 · 2021-11-16T05:25:35.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`38ff15b`	`src/sage/geometry/polyhedron/base.py: Add missing sage.rings.number_field`

Answer 17 · 2021-11-16T05:26:59.000Z

Changed commit from 38ff15b to f2d72d3

Answer 18 · 2021-11-16T05:26:59.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f2d72d3`	`src/sage/geometry/polyhedron/parent.py: Remove unneeded import`

Answer 19 · 2021-11-16T05:27:23.000Z

Changed dependencies from #32776, #32732 to #32776, #32732, #32174

Answer 20 · 2021-11-21T03:49:35.000Z

Changed commit from f2d72d3 to 51ccab2

Answer 21 · 2021-11-21T03:49:35.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7a81ba8`	`move lattice point methods to Polyhedron_base2`
`10dd56d`	`remove unused import`
`6a15f92`	`move combinatorics to Polyhedron_base3`
`f7d87e2`	`fix copy/paste-typo`
`6160076`	`Merge branch 'u/gh-kliem/polyhedron_base3' of git://trac.sagemath.org/sage into u/gh-kliem/polyhedron_base4-new`
`ff8c7ef`	`move methods relying on sage.graphs to Polyhedron_base4`
`51ccab2`	`Merge #32889`

Answer 22 · 2021-11-21T03:49:51.000Z

Changed dependencies from #32776, #32732, #32174 to #32776, #32732, #32174, #32889

Answer 23 · 2021-11-21T20:22:38.000Z

comment:16

messed up the merge

Answer 24 · 2021-11-21T20:25:20.000Z

Changed commit from 51ccab2 to 1c028c7

Answer 25 · 2021-11-21T20:25:20.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`1c028c7`	`Merge #32889`

Answer 26 · 2021-12-07T08:36:42.000Z

comment:19

LGTM.

Answer 27 · 2021-12-07T08:36:42.000Z

Reviewer: Jonathan Kliem

Answer 28 · 2021-12-08T01:02:54.000Z

comment:20

Thanks!

Answer 29 · 2022-01-31T23:31:12.000Z

Changed branch from u/mkoeppe/sage_geometry_polyhedron__more___optional to 1c028c7