sagemath/sage

sage.matrix: Modularization fixes after #33159

Closed this issue · 11 comments

We add # optional - sage.symbolic doctest tags
after #33159.

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 2f8a489

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33392

Commit: 2f8a489

New commits:

b28224bsrc/sage/matrix/matrix2.pyx: Add # optional - sage.symbolic
2f8a489src/sage/matrix/matrix2.pyx: Use sage.rings.abc.SymbolicRing for isinstance testing
comment:3

How can I test this? And how do we prevent this from happening again?

comment:4

I noticed it by running #32432 (see test instructions on the ticket description).

comment:5

Replying to @mwageringel:

how do we prevent this from happening again?

When #32432 or #32601 are merged, we can add it to our automated tests.

slel commented

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
-
+We add `# optional - sage.symbolic` doctest tags
+after #33159.

Reviewer: Michael Orlitzky

comment:7

Well, it can't hurt. Except for that one isinstance() which LGTM.

comment:8

Thanks!