LSP saga floating window design
kaykhan opened this issue · 9 comments
Hi using im using lsp saga and hovering over a function a floating window appears. I want to remove the padding on this floating window and change the background color of it.
Any idea how i might go about doing that by modifying this theme?
That looks like a bug to me, see the following issue for the expected rendering of LSP Saga's pop-ups: sainnhe/everforest#88
You closed the issue almost immediately after opening it, does it mean you found a solution? If yes, could you please share your findings?
@antoineco My issue was completely different and i resolved it on my own.
But i realised what i had shown does resemble that issue in the referenced issue on everforest.
I was able to replicate that problem on sonokai.
Strange, we fixed that in #67. Maybe something changed in LSP Saga since that fix.
OK looks like there were indeed a couple of breaking changes introduced in LSP Saga, and there is now a single highlight group for all diagnostic borders: https://github.com/glepnir/lspsaga.nvim/blob/44af2ab1/lua/lspsaga/highlight.lua#L60
Ref. nvimdev/lspsaga.nvim#586 (highlight.lua)
OK looks like there were indeed a couple of breaking changes introduced in LSP Saga, and there is now a single highlight group for all diagnostic borders: https://github.com/glepnir/lspsaga.nvim/blob/44af2ab1/lua/lspsaga/highlight.lua#L60
Ref. glepnir/lspsaga.nvim#586 (
highlight.lua)
Will there be a fix made in this theme to support this change?
Yes, and ported to all sainnhe's color schemes as soon as I test the potential fix locally.
I just looked into this issue and things are a bit more granular than I though.
By default, LSP Saga has the option diagnostic.border_follow set to true. In this configuration, the borders of all diagnostic pop-ups are rendered with the highlight group of the corresponding diagnostic type.
For example, a Hint pop-up is created with a border which highlight group is linked to DiagnosticHint. If I re-link DiagnosticHint to Green, the border changes as follows:
This is bad for two reasons:
- LSP Saga hijacks highlight groups related to text for graphics.
- We render
DiagnosticHint, etc. with undercurl to emulate the style adopted by most IDEs to highlight code related to a diagnostic.
Before, we could get away with setting LspSagaDiagnosticHint, etc. to a non-undercurl style. Since the recent changes in LSP Saga, it is no longer possible to customize LSP Saga specifically. In my opinion this is a regression, and plugins should under no circumstances expect to be customized only through Vim's internal highlight groups, especially to render graphical elements.
Some plugins—like lualine for example—are graceful enough to allow the user to customize fallback groups. LSP Saga could adopt a similar approach and use DiagnosticHint by default, while honoring LspSagaDiagnosticHint if it exists.
We are most definitely not going to override internal highlight groups to accommodate one specific plugin, so unless the author of LSP Saga changes their approach to border rendering, LSP Saga won't be supported in Sonokai / Gruvbox material / Everforest / Edge moving forward.
Okay i appreciate the effort looking into this. Maybe its something to bring up to the maintainer of LSPSaga.
Cross referencing sainnhe/everforest#136 (same root cause)