salvoravida/redux-first-history

Inconsident behavior on null path between production and development

Opened this issue · 0 comments

Using
"redux-first-history": "5.2.0",
"history": "4.10.1" (goes with router v5)
"react-router-dom": "5.3.4"

When I dispatch a push() with a null value the behavior is different in developement vs production.

In Dev: No URL change
In Production: Removes query params from existing URL

This is caused by of a dev check in the history push method (see screenshot).

Possibly expected behavior, had same behavior in connected-react-router but could be fixed with an earlier null check?

image