samoliverdev/UnityURPAtmosphericFog

You can only call cameraColorTarget Inside the Scope of a Scriptable Render Pass

Opened this issue · 3 comments

I get this error upon adding the renderer feature.

https://imgur.com/a/36K4xlp

The error displays twice every frame... Any idea on how to fix it?

Edit: I found out this is a new issue with this code becoming obsolete
m_ScriptablePass.source = renderer.cameraColorTarget;
But after doing a bunch of reading I cannot figure out how to fix it...

Hi. I attempted to make this work with 2022.2 and this is the result: https://github.com/andrew-raphael-lukasik/Unity-URP-atmospheric-fog/blob/main/AtmosphericFog/AtmosphericFogRenderFeature.cs
Outside of my field of expertise here but noticed that Create/Rendering/URP Renderer Feature creates a default script with a different method names so I moved everything over to this new code layout. Works ¯_(ツ)_/¯

Oh, thank you, i didn't get a notification for this. I copied your script, and there's no errors anymore, but i'm not sure why, it's not working. Here's a video,
https://youtu.be/ULxf12tOdWM
Basically all i wanted to do was make it so the fog is near the top of this beanstalk, and weaker down near the bottom. I don't know if this render feature works for that? I thought i could make the height fog thicker and the lower fog thinner, but nothing is changing when i alter the options. i know i have this shader added in "always include" and depth texture is enabled... Only the top "General" settings seem to do anything.

Edit: Forgot to mention, i added the range attributes just to make it easier to adjust the values, i didn't change anything else in the script though lol

No idea, works fine on my machine

GIF 17 01 2023 14-37-26