samsonjs/strftime

Assertion fails

adamatan opened this issue · 4 comments

adamatan commented

[ OK ] Exports

assert.js:92
throw new assert.AssertionError({
^
AssertionError: strftimeUTC("%C", Fri Jan 01 100 00:00:00 GMT+0200 (EET)) is "00", expected "01"
at _assertFmt (/private/tmp/strftime/test/test.js:26:12)
at Function.assert.format (/private/tmp/strftime/test/test.js:32:3)
at Object. (/private/tmp/strftime/test/test.js:44:10)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:901:3

samsonjs commented

Oops, when the TZ environment variable was empty I assumed my own time zone for some zone specific tests. Fixed by SHA: 0052ee0 and will be rolled into the next bug fix release.

Thanks for the report. 🍻

adamatan commented

Great!
I'm drafting a Hebrew translation. Will you be interested in merging
localization objects into your code?

On Wednesday, November 20, 2013, Sami Samhuri wrote:

Closed #31 #31.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/31
.

samsonjs commented

That's an interesting idea. I bet we could collect a lot of the most common languages relatively quickly. Please do!

adamatan commented

Sami,

Here's my Hebrew locale object and some
testshttps://gist.github.com/adamatan/7602005
.

I suggest that we add some locale files to a subdirectory, and create a
separate minified file for each of them (e.g. strftime-min.js,
strftime-he_IL.min.js, strftime-it_IT.min.js, ...).
Each minified file will only contain the English object and the
corresponding locale file. This will keep the minified versions small,
which is good for page loading speed.

We can reuse the current localization
testhttps://github.com/samsonjs/strftime/blob/master/test/test.js#L145
for
all othe locales.

What do you think?
Adam

On Wed, Nov 20, 2013 at 10:16 PM, Sami Samhuri notifications@github.comwrote:

That's an interesting idea. I bet we could collect a lot of the most
common languages relatively quickly. Please do!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/31#issuecomment-28926640
.