Nice!
Opened this issue · 1 comments
ziriax commented
(this is not an issue but just some feedback)
So nice to see a cross platform version of the DAE educational 2D engine!
The code looks amazing. Some tiny remarks:
SoundStreamandSoundEffectcould share a base-class, e.g.SoundResource, with common methods?- Love the split between Vector and Point! You could also have introduced homogeneous points (x,y,w), most likely not done because students don't learn this?
- I don't see any smart pointers being used. Is this taught to students? Raw persistent pointers are rarely used in modern C++ code bases.
- You implemented all the drawing logic in OpenGL. Any reason why not using Google Skia, the rendering engine behind Android, Chrome and Edge? That can be used with SDL, and offers a lot of 2D level drawing functionality. It is of course a huge dependency yes.
- Does it work on MacOS?
samynk commented
Merci voor de feedback!
- SoundStream en SoundEffect zijn idd heel gelijkaardig, het enige verschil
is dat een soundeffect op een nieuw channel kan afgespeeld worden (zodat
soundeffects kunnen overlappen). Dit lijkt zelfs meer op iets
dat via data configuratie kan gedaan worden (helaas zijn het wel andere
methodes en objects die moeten gebruikt worden).
- Homogenous zou goed zijn , ben ik ook voorstander van, het komt zo mooi
samen , en wordt idd wel gezien in eerste semesters.
- Smart pointers zijn tweede jaar.
- OpenGL is historisch, heb nu vooral gewerkt rond het build systeem en het
bruikbaar maken op Linux. Ik ga zeker eens kijken naar betere manieren om
het renderen zelf te verwezenlijken. Interessant dat Skia in combinatie met
SDL kan werken, dit wist ik niet!
- MacOs zou ik willen doen, maar heb zelf geen Mac dus is moeilijk uit te
testen , moet nu al rekenen op studenten om de Linux build uit te testen ;)
mvg,
Koen
…On Fri, Mar 17, 2023 at 12:52 PM Peter Verswyvelen ***@***.***> wrote:
(this is not an issue but just some feedback)
So nice to see a cross platform version of the DAE educational 2D engine!
The code looks amazing. Some tiny remarks:
- SoundStream and SoundEffect could share a base-class, e.g.
SoundResource, with common methods?
- Love the split between Vector and Point! You could also have
introduced homogeneous points (x,y,w), most likely not done because
students don't learn this?
- I don't see any smart pointers being used. Is this taught to
students? Raw persistent pointers are rarely used in modern C++ code bases.
- You implemented all the drawing logic in OpenGL. Any reason why not
using Google Skia, the rendering engine behind Android, Chrome and Edge?
That can be used with SDL, and offers a lot of 2D level drawing
functionality. It is of course a huge dependency yes.
- Does it work on MacOS?
—
Reply to this email directly, view it on GitHub
<#4>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALO2MKAP5CWL2MI5NTB4MLW4RGARANCNFSM6AAAAAAV6NZYII>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>