incbin always null in DotGenerator.java
theNestruo opened this issue · 1 comments
theNestruo commented
I haven't actually tested it yet, but pulled the code and this warning arose:
sb.append(nodeNames.get(s.incbin));
DotGenerator.java#102
Unlikely argument type File for get(Object) on a Map<String,String>
Seems legit; nodeNames is a Map<String, String>
and s.incbin is a File
, hence this line will always append "null"
.
santiontanon commented
Ah good one! "incbin" used to be a String with the filename, but now it's a File object, and forgot to update the DotGenerator worker! Thanks!! Fixed :)