sbi-dev/sbi

refactor neural_nets module

janfb opened this issue · 1 comments

janfb commented

The sbi/neural_nets is a bit of a mess:

  • it has embedding networks, ratio estimators, all kind of build functions on the top level
  • and a submodule density_estimators containing the ConditionalEstimator base class (which is not really a density estimator) and the corresponding flow-based ConditionalDensityEstimator classes.

Suggested fix: group the modules into helper functions / build functions vs. neural networks / classes implementing estimators vs utils.

janfb commented

duplicate of #991