sbt/sbt-bundle

Enhance check command configuration

huntc opened this issue · 1 comments

huntc commented

Provide a setting for the check command's --initial-delay parameter. This parameter controls how many seconds to wait until the check command checks anything.

Also document that a check command may have the following declaration:

    BundleKeys.checks := Seq(uri("$ES_INTERNAL_HOST?retry-count=10&retry-delay=3")),

The accepted params are:

  • "retry-count=" - number of retries;
  • "retry-delay=" - delay in seconds between retries; and
  • "docker-timeout=" - timeout in seconds for docker container start

I've looked into SbtBundle.scala and check.py. But I am still a bit confused how to add the --initial-delay parameter to the BundleKeys.checks command. How does the user specify this setting in the build.sbt?

  • As a checks argument: BundleKeys.checks := Seq(uri("$ES_INTERNAL_HOST?retry-count=10&retry-delay=3&initialDelay=5")) OR
  • With a separate BundleKeys command: BundleKeys.initialDelay := 5s OR
  • Somehow else

The accepted params are:

"retry-count=" - number of retries;
"retry-delay=" - delay in seconds between retries; and
"docker-timeout=" - timeout in seconds for docker container start

This needs to be only documented in the README.md or should we add validation in the SbtBundle.scala as well?