File Close documentation
Closed this issue · 3 comments
Landryj commented
Add a sentence to the 'filename.tofile' operation that informs to the user that after the file is written it does not close and a 'filename.close()' is required.
scott-griffiths commented
Thanks, yes that's reasonable. I can't quite remember why the tofile
method exists if I'm honest - if the user has to do the open and close they might as well just write the result of tobytes()
instead.
Landryj commented
Scott, thank for your response. '.tofile()' is something that a novice like me would search for to save something. Another sentence in the .tofile() might point readers to 'tobytes()'. I appreciate your work to build and maintain the module. John
From: Scott Griffiths ***@***.***>
Sent: Monday, December 30, 2024 11:11 AM
To: scott-griffiths/bitstring ***@***.***>
Cc: John Landry ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [scott-griffiths/bitstring] File Close documentation (Issue #352)
NOTICE: This email originated from outside the University. Please exercise caution when replying or opening links and attachments.
Thanks, yes that's reasonable. I can't quite remember why the tofile method exists if I'm honest - if the user has to do the open and close they might as well just write the result of tobytes() instead.
-
Reply to this email directly, view it on GitHub<#352 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADTY5ZFJ47YTYG5KSMYCWCD2IGEDJAVCNFSM6AAAAABUMLKKKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVG43TSNBVGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Landryj commented
Thanks. John
On Jan 1, 2025, at 2:41 AM, Scott Griffiths ***@***.***> wrote:
NOTICE: This email originated from outside the University. Please exercise caution when replying or opening links and attachments.
Closed #352<#352> as completed.
—
Reply to this email directly, view it on GitHub<#352 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADTY5ZHNVUE6YK43MWOPHV32IOZ6BAVCNFSM6AAAAABUMLKKKGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG44TGMZQGUYDMMA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>