OpenTelemetry Specification compliance
Closed this issue · 4 comments
The approach of integrating Serilog with OpenTelemetry Logs is NOT compliant with OpenTelemetry specification.
The OpenTelemtry SDK should accept a logger provider via Bridge API which is not done yet (see: open-telemetry/opentelemetry-dotnet#4433)
As far as I understand correctly, the Serilog Sink ("log appender" in OpenTelemetry specification) would only have to depend on OpenTelemetry.Api NuGet package.
Maybe the fact that the design is not OpenTelemetry Specification compliant could be mentioned in the docs?
Originally posted by @pellared in #73 (comment)
The sink's aiming for compliance with the OpenTelemetry protocol. I'll call that out in the README 👍
The sink aims for full compliance with the OpenTelemetry Logs protocol. It
does not depend on the OpenTelemetry SDK or .NET API.
Thanks!
That works fine and hopefully decreases potential confusion. In future, there could be a separate Sink/adapter that would work with OpenTelemtry Logs Bridge API.
Definitely! This is what OpenTelemetry.Extensions.Serilog does, I think, so hopefully that will be the solid solution for those looking for integration into the SDK 👍