servalproject/serval_chat

Nearby identities issue

Closed this issue · 7 comments

image

Getting an unknown identity like above sid:****. Is this related to the first issue of issues in readme?

If yes, please let me know how could I solve this internally @lakeman

So, Is there a way to disable until implementing? Currently, I did a workaround to look for the coming peers with null lookup but that not efficient

https://github.com/servalproject/serval_chat/blob/development/app/src/main/java/org/servalproject/mid/KnownPeers.java#L169

What about this? This will always read 3 though it must be 2. putting Lookup with null doesn't help in this function as routeResults may not get called again after dnaResults called and vice versa

We also have a grant application in the signing stage that would allow us to implement a kind of business card that would be able to be shared on the network to allow delay-tolerant resolution of SIDs into names. Paul. On Thu, 9 Apr 2020 at 23:00, Jeremy Lakeman notifications@github.com wrote:

You can either (or both) hide peers until they respond to a Lookup; https://github.com/servalproject/serval_chat/blob/development/app/src/main/java/org/servalproject/mid/KnownPeers.java#L58 or delay the handling of networks; https://github.com/servalproject/serval_chat/blob/development/app/src/main/java/org/servalproject/mid/networking/Networks.java#L50 On Thu, 9 Apr 2020 at 22:38, Assem @.***> wrote: > So, Is there a way to disable until implementing? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #15 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAEQHXRIVFG5WF4UBPHQPJ3RLXCFZANCNFSM4MEFVFIA > > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFCOT4PSMPLH7FVTMDKPFTRLXEXRANCNFSM4MEFVFIA .

That would be great but bear in mind that the displayed SID above in the picture comes from an unknown place, Maybe serval-dna created it internally for a reason (I didn't reach to it yet in c++ side) but I don't know if it related to the first issue of the issues in the README. Therefore, You also need to check if this SID related to a real/existed identity or not.

I would like to say as well I'm building a wrapper to link serval-dna with react-native and I'm almost done with it. Actually, I did this for many reasons but most importantly are because react-native doesn't have a really good library to provide offline actions between devices (send files/messages) and second the powerful of serval-dna you guys really did a great job.