Support crown on windows without hacks
Opened this issue · 7 comments
We need proper solution for #32300. Dylint has some interesting solutions: trailofbits/dylint@c222181
Ah, this explains the recent issue I had on windows.
Do we need to use crown on all platforms? I've been wondering if we could turn crown off by default, and only enable it in CI / ondemand.
Ah, this explains the recent issue I had on windows.
I should probably add workaround in mach instead of CI file.
Do we need to use crown on all platforms?
I think not as it only does additional pass of lints on script crate, which do not have (I think) any platform specific cfgs where lints are actually linting (dom structs).
I've been wondering if we could turn crown off by default, and only enable it in CI / ondemand.
That's the ultimate plan, as only those who do changes in script crate needs to run it.
That's the ultimate plan, as only those who do changes in script crate needs to run it.
Is there anything blocking this? Couldn't we just delete rustc = "crown" from the config.toml, and in CI set CARGO_BUILD_RUSTC=crown and add an optional parameter to mach which also sets this environment variable?
I'm ok with that. We may want to start by updating thevPR template to have a checklist item about running crown if any script changes are included.
I'm ok with that. We may want to start by updating thevPR template to have a checklist item about running crown if any script changes are included.
CI would still run crown, so I do not think we would need this (I never really understand tidy and build on PR checklist as this is checked by PRs CI check anyway).
CI would still run crown, so I do not think we would need this (I never really understand tidy and build on PR checklist as this is checked by PRs CI check anyway).
I think this is still pretty useful as it can help reduce some back-and-forth between new contributors and reviewers. In addition, sometimes I only remember to run tidy when I am filling out the PR template. 😅