setchi/FancyScrollView

Instantiate cell object from prefab

rfadeev opened this issue · 3 comments

Is there any special reason for instantiating cells from cellBase which is set to inactive in FancyScrollView's Awake? I was thinking that support of instantiating from prefab can be useful, plus it would allow not having disabled cellBase object in heirarchy.

Thank you.

Certainly, I think it is convenient to instantiate from prefab.
I tried it, there seems to be no problem. I updated samples. 32d4195
Please tell me if you have any comments.

@setchi Great, thanks! Actually I was thinking to implement this, but was afraid of too drastic API change since FancyScrollView users need to extract their objects from heirarchies to prefabs, otherwise they would have enabled instance of "original" cell base. For example Unity UI Extensions project could be affected if they would like to update their FancyScrollView code to this version.

One comment: prefabs for examples 1 and 2 are disabled, while for examples 3 and 4 are enabled. Is it intended?

I did not intend. Fixed! 8ed0641
Thanks.