setzer22/blackjack

Impossible to zoom and hard to trigger click

Kerollmops opened this issue Β· 7 comments

Kerollmops commented

I tried blackjack on my MacBook Pro 13' M1 and found out that it was impossible to zoom by using the "roulette wheel" i.e. on my trackpad and pretty hard to trigger the right-click menu I found this related issue #1 but it doesn't seem to be entirely fixed.

setzer22 commented

Thanks for reporting! A few questions:

  • Do regular clicks work fine? If so, this is not the same as #1
  • I'm not sure what you mean by the "roulette wheel" πŸ€” does any other way of zooming work?
  • Does the problem with zooming occur both on the 3d viewport and the node graph?
Kerollmops commented

Yup, regular clicks work fine!

  • I'm not sure what you mean by the "roulette wheel" πŸ€” does any other way of zooming work?

Sorry, I mean mouse wheel i.e. two fingers on my trackpad.

  • Does the problem with zooming occur both on the 3d viewport and the node graph?

I am on the feat/properties_inspector branch and I am able to zoom on the graph when I hover the 3d scene πŸ˜„
I am also unable to rotate or zoom on the 3d scene viewport.

You can compare this screenshot to #6 (comment)

Capture d’écran 2022-01-30 aΜ€ 17 51 49

Kerollmops commented

I am also unable to rotate or zoom on the 3d scene viewport.

I am, I just found out that I can control the 3d scene viewport only by hovering a small square top right, something like half of the actual viewport size. It seems like the visual viewports are not of the same size as the control viewports, something like half the size.

I confirm that for the zoom and rotate mouse controls but I can effectively control the size of the panel by correctly controlling the green lines. That is probably handled by another part of the code.

setzer22 commented

Oh, I see what you mean! I was able to reproduce this by forcing a dpi factor of 2.0 on my end πŸ‘ I must be doing something wrong with the dpi when translating mouse events for the child viewports.

Let me see if I can get it sorted out πŸ˜„

  • πŸ‘1
setzer22 commented

I think it should be working now πŸŽ‰ Can you verify on your end? Pulling b2ce067 should get you both a fix for this and #6

Kerollmops commented

That's indeed fixed, thank you! πŸŽ‰

Just a small improvement would be to reduce the speed of the zoom speed, it is very difficult to be precise as it is very fast to zoom and unzoom.

setzer22 commented

Cool! I'll close #6 and #7 then :) I'll be tracking this zoom speed issue in #8