shadps4-emu/shadPS4

[Feature Request]: Sync the QtLauncher PRs with the main repo

Closed this issue · 6 comments

Checklist

  • I have searched for a similar issue in this repository and did not find one.

Description

Currently, the QtLauncher has a lot of stuff over the normal shadPS4 qt executable you can get on the main repo, this puts it behind and is inconvenient for users (for example, recently the PR to add memory was merged, the normal Qt executable doesn't have a GUI implementation but the QtLauncher does, and the more time passes the more stuff will be added to the launcher and not on main, I think either syncinc the PRs on both repo or merging the QtLauncher to the main repo would be the proper way to handle this (assuming the QtLauncher is usable currently, haven't checked).

Reason

For user convenience.

Examples

No response

qt will be removed from main repo when qtlauncher is ready for production (still have a few bits left) . That will eventually happend in v0.12.0 so main repo won't receive qt updates anymore

I understand but that means nightly doesn't offer anything over release this time, at least in the interface, also you won't be able to get as much testing since it's on a different repo, I think if the QtLauncher is usable you should merge it ASAP so that everyone can test it, this way it's easier to find issues, I believe that's the main reason why nightly exist, to test experimental stuff even if it's broken a bit.

changes to qt are mostly UI relative and doesn't need extensive test i believe . Merging in main would be overkill. QtLauncher is also production ready and i guess it will be released by the end of this month. At the same time the plan is to remove qt from main repo so emu will be bundle as sdl only executables that can be used with qtlauncher

If you're sure about this then I won't object, I still think it would be nice to have some of the Qt features on nightly instead of keeping them exclusive to the launcher.

you can use qtlauncher nightly with sdl shadps4 nightly it works ;)

I know it works, that's not an issue with me, I can set up those things but I don't think the average shadPS4 user can and want to set it up (as easy as it is).