shiming-chen/HSVA

Missing functions in models.py

Closed this issue · 4 comments

The following functions seem to be missing in models.py:

  • models.discriminator_template()
  • models.decoder_z()
  • models.domain_classifier()
  • models.domain_discriminator()

Can you make these available?

Kind Regards

Sir, have you solved this problem? @roman-studer

Hi, @roman-studer @LZhongYue
Thanks for your attention on our work. We have added the the related functions in model.py.
Best!

Shiming

Thank you Dr. Chen, I have successfully run HSVA, I hope one day I can also post the top conference☀@shiming-chen

Thank you very much for the reply and the changes. I have also been able to run HSVA.

FYI, I had to change self.discriminator[datatype] = models.discriminator_template(dim, 1, self.hidden_size_rule[datatype], self.device) in HSVA.py to self.discriminator[datatype] = models.domain_discriminator(dim, 1, self.hidden_size_rule[datatype], self.device) and am assuming that models.domain_discriminator functions the same as models.discriminator_template.

Kind regards