Implementation of Quote Card with [Background Image](https://codepen.io/governorfancypants/pen/elsDc)

Question

Implementation of Quote Card with [Background Image](https://codepen.io/governorfancypants/pen/elsDc)

Closed this issue 3 years ago · 12 comments

Is your feature request related to a problem? Please describe.
Implementation to have a background image instead of solid colour

Describe the solution you'd like
Implementation of adding a background image as optional instead of solid colour

Additional context
Not just new card, but also with existing cards as well.

Answer 1 · 2021-10-01T08:08:39.000Z

just like #124, we can add another option of a background image with single or gradient color. we can keep images in a folder and the user can traverse through them using the next button with we can implement if the user selects image instead of gradient or single color
so I think both #123 and #124 can be implemented through the same approach

Answer 2 · 2021-10-03T06:13:08.000Z

Hi @Rispectech
I have assigned both the issues to you!
THank you so much for your time :)

Answer 3 · 2021-10-03T06:18:58.000Z

sure thanks a lot @shravan20. actually, I was quite busy because of prior arrangements so I think I won't be able to work on this for the next week or 2 most probably. so if u are fine with that then all is good.
but since the project is really impressive I would like to work on it if it isn't taken by anyone else

Answer 4 · 2021-10-03T06:51:18.000Z

This wont be an issue. Take your time. :)

Answer 5 · 2021-11-03T12:07:49.000Z

Hey @Rispectech are you still working on it? If you don't have time i can take up this issue.

Answer 6 · 2021-11-03T12:38:56.000Z

hey @dolmushcu . i just started working on the issue so i will be grateful if i can get some more time . if i am unable to solve it within the next 2 weeks , you can take the issue .
i think we can go it this way you can do #123 while i can work on #124 . can this work ?
Sorry for the inconvienve . hope you can comply with it . Thank you

Answer 7 · 2021-11-03T13:06:46.000Z

Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet.

Answer 8 · 2021-11-04T07:57:05.000Z

Hi @dolmushcu
#124 is a different feature implementation compared to this one. Both will have different approaches. We cannot go with the same approach.

Answer 9 · 2021-11-05T06:26:20.000Z

Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet.

if that's the case , then please go ahead with the issue because its true that i am a bit busy . Thanks for the help .
and about your comments being indiscreet, i would say it was me who was being disrespectfull since the issue has been sitting for more than a month now so your comment was completely right on the mark . so please go ahead with the issue
again sorry for my behavior

Answer 10 · 2021-11-05T14:00:08.000Z

Hi @dolmushcu #124 is a different feature implementation compared to this one. Both will have different approaches. We cannot go with the same approach.

Here is what i thought:
In the file where the themes being specified (src/themes/themes.js), we could pass bg_color values directly. I mean right now # character is being added automaticly assuming every value that passed is hex in the layout file. However if we let people pass quote_color, bg_color... freely, they could be able to pass gradient color and image.

EXP: bg_color: "linear-gradient(to right, #0f2027, #203a43, #2c5364)"
EXP: bg_color: "url('http://example.com/image.png')"
EXP: bg_color: "#fff"

When i mention about same approach i was talking about something like this. What do you think? Does this approach have any drawback?

Answer 11 · 2021-11-05T14:01:09.000Z

Absolutely, i thought i should ask, if you're busy or something i thought i could be helpful. There is no inconvenience. As for the splitting issues, i guess these two issues could be solved with the same approach, so you should take up both. Sorry if my recent comment is a bit indiscreet.

if that's the case , then please go ahead with the issue because its true that i am a bit busy . Thanks for the help . and about your comments being indiscreet, i would say it was me who was being disrespectfull since the issue has been sitting for more than a month now so your comment was completely right on the mark . so please go ahead with the issue again sorry for my behavior

i feel like we've been missunderstood eachother, you should work on it if you'll have time and i will open a PR in a month if you haven't yet.

Answer 12 · 2021-11-10T13:15:43.000Z

Hi @dolmushcu #124 is a different feature implementation compared to this one. Both will have different approaches. We cannot go with the same approach.

Here is what i thought: In the file where the themes being specified (src/themes/themes.js), we could pass bg_color values directly. I mean right now # character is being added automaticly assuming every value that passed is hex in the layout file. However if we let people pass quote_color, bg_color... freely, they could be able to pass gradient color and image.

EXP: bg_color: "linear-gradient(to right, #0f2027, #203a43, #2c5364)" EXP: bg_color: "url('http://example.com/image.png')" EXP: bg_color: "#fff"

When i mention about same approach i was talking about something like this. What do you think? Does this approach have any drawback?

Sounds perfect