Forced stdout breaks remote sessions
Closed this issue · 3 comments
pevogam commented
Hi @sibson,
Is there any reason why two functions in the client module output explicitly to stdout instead of using the provided loggers? Some of our remote sessions break down because of some of this output and there isn't any easy way to prevent the output from being emitted. We already make full use of the logging levels and filters but the following code doesn't seem to respect that.
Any feedback is appreciated.
sibson commented
provided the default ./vncdo logging configuration prints the strings, I
don't see a reason not to change it to be.a proper logger. I'll merge a
PR, but don't have time to make the change myself.
…On Fri, Jan 21, 2022 at 10:48 AM Plamen Dimitrov ***@***.***> wrote:
Hi @sibson <https://github.com/sibson>,
Is there any reason why two functions
<https://github.com/sibson/vncdotool/blob/17e66252fa7a72eccef8cc9b837543aed30524f0/vncdotool/client.py#L390>
in the client module output explicitly to stdout instead of using the
provided loggers? Some of our remote sessions break down because of some of
this output and there isn't any easy way to prevent the output from being
emitted. We already make full use of the logging levels and filters but the
following code doesn't seem to respect that.
Any feedback is appreciated.
—
Reply to this email directly, view it on GitHub
<#211>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6R2XQOG4R6LVQ4PVSBULUXF54LANCNFSM5MP3K7EQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
pevogam commented
No worries, I will push a PR. Thanks for the quick response!