No support for Dir[] or Dir.glob

Question

No support for Dir[] or Dir.glob

sgerrand opened this issue 10 years ago · 12 comments

There is currently no support for the Dir[] or Dir.glob methods in MemFs. Ideally these methods should be implemented as part of full emulation of the Dir class in Ruby core.

Answer 1 · 2014-04-18T07:52:49.000Z

You're right. I've been thinking about it for some time.

The complexity comes from the globbing part, I could try to transform the string to a Regexp and match this way. In the mean time, I'll add a basic one handling a simple string or array. That's a start :)

Answer 2 · 2014-04-18T07:54:45.000Z

Thanks for responding so quickly. I've started done preliminary work on it
myself.

Answer 3 · 2014-04-18T08:04:56.000Z

What angle did you chose to handle the different globing options?
If you're interested we could pair on it :)

Answer 4 · 2014-04-18T08:22:15.000Z

Ok, looking at the documentation, all globing can be done with File.fnmatch which is already implemented, so the implementation should be really easy! \o/

Answer 5 · 2014-04-18T08:28:23.000Z

That's the approach I started on. Great minds! ;)

Answer 6 · 2014-04-18T08:29:43.000Z

Awesome! :)

Answer 7 · 2014-06-16T17:41:05.000Z

@sgerrand Hi, any progress?

Answer 8 · 2014-06-16T18:12:43.000Z

Hi, any progress?

Sorry, not as yet. I let this slip. Will try and complete the feature this
week.

Answer 9 · 2014-06-16T18:39:22.000Z

@sgerrand tell me if you need help or if you have any question ;)

Answer 10 · 2014-07-18T08:49:01.000Z

Hey guys. I added a basic implementation of Dir.glob and will soon drop Dir[]. Hope you like it ;)

Answer 11 · 2014-07-18T08:53:56.000Z

And done :) Now that Dir is complete (except for mktmpdir) I'll push a new release.

Answer 12 · 2014-07-18T09:09:27.000Z

Great! Thanks for doing this. :D