simonpoole/beautified-JOSM-preset

Some highway types are missing in chunk "highway_types" and in the item for highway=construction

jajajaneeneenee opened this issue · 1 comments

I noticed that these highway types are missing in the chunk "highway_types" in combo key="highway" (which is only used for junction=roundabout and junction=circular):

  • secondary_link
  • tertiary_link
  • road
  • busway

(But is has motorway_link, trunk_link and primary_link.)

And in the item "Construction" (highway=construction) this highway type is missing in combo key="construction":

  • road

Perhaps is it intentional, I'm not sure. I just wanted to share it.

Other notes/suggestions to the chunk "highway_types" and the item "Construction":
(Sorry not to have created my own issues for this, it seems too minor to me).

  • Perhaps a values_sort="false" would make sense for the "highway type" combos.
  • I would rename "Construction" it to "Highway construction", just to make it clearer – because there is also "Railway construction" (railway=construction) for example.
  • The wiki link in item "Construction" could be changed to <link wiki="Tag:highway=construction"/> (it's <link wiki="Key:construction"/> now). It also could be changed in item "Railway construction" ...
  • You could also add list_entry icons in chunk "highway_types" (see combo key="construction" in item "Construction").

I just noticed this about the item for highway=construction and this combo:

<combo key="junction" text="Junction" values="roundabout,jughandle,yes"/>

  • display_values are missing (lowercase values will be displayed in the editor)
  • the values circular and filter could be added