simonpoole/beautified-JOSM-preset

Type of item "Public Market" (amenity=marketplace)

Closed this issue · 2 comments

jajajaneeneenee commented

According to the Wiki, type should be type="node,closedway,multipolygon" (now it's type="node,way,closedway").

simonpoole commented

You can argue about the multipolygon, but excluding linear features is clearly wrong and can be traced back to a well known wikifiddler.

jajajaneeneenee commented

Hmmm ... OK ... then openway should be possible for amenity=marketplace? Really "clearly wrong" to exclude that? What makes it so clear to you? I'm thinking about what that might look like. A line parallel to a street (as is possible, for example, with public_transport=platform)? Or as an additional tag ON a highway (openway) line? I never saw something like this, but perhaps it exists. Hard to query for something like that with OverpassTurbo. I first tried with the Wizard query amenity=marketplace AND highway=* AND highway!=pedestrian AND type:way global and I found very very few examples of openways.

  • Query result was 59 ways of 82.832x amenity=marketplace in all types, but most of them closedways, too – OverpassTurbo says: 23 ways and 36 polygons – and I didn't check all 59 results ...),
  • Without excluding highway!=pedestrian (mostly areas) the result is 32 ways and 392 polygons
  • A query without highway=* (amenity=marketplace AND type:way global) results in 56 ways (I think this means openways) and 47.789 polygons (40 MB query result).
  • If it is really used only 56x worldwide on openways, this corresponds to a percentage of approx. 0.07% (56 of 82.832x amenity=marketplace). Not what I expected for a "clear" include of openways ... But not 100% sure, if my query or the interpretation of the query is correct ...

But here are 2 examples for openways:

Here is a multipolygon by the way (a somehow strange one):

And I saw in the version history of the Wiki that it was "onWay = yes" until 2017-10-18 (then changed by user Geozeisig) ... There are often corrections to the type in the wiki – and usually justified (I therefore rely quite a bit on what is stated in the wiki, although of course that doesn't always have to be correct).

And the description in the Wiki also says: "Set a node or draw as an area along the outline of the marketplace and add amenity=marketplace". (But also added by user Geozeisig in 2017-10).

I would think, that somebody else would have changed this again since 2017 if it is really wrong (or a good practise to use it on openways, too) ... but who knows ... It looks for me like some kind of an agreement, that the best practice is to use it on a node or on a closedway (or multipolygon) and that it should be avoided to use it on a closedway. (Seems to have a logic to me when I think about rendering, where in a marketplace it might often make sense to display an icon. Difficult on an openway.)

However, the proposal from 2009 says nothing about the type ...