more helpful errors

Question

more helpful errors

Closed this issue 5 years ago · 5 comments

setting an invalid interlock threshold gives the error "b'[scpi] **ERROR: -200, "Execution error"\r\n'" this is not very helpful, and will make debugging hard. Can we have slightly more descriptive errors (we don't have to stick rigidly to the SCPI standard for this)?

hartytp commented 5 years ago

Thanks!

Answer 1 · 2019-09-03T13:57:57.000Z

Added some more meaningful errors
[scpi] **ERROR: -99, "Channel not detected"
[scpi] **ERROR: -98, "Interlock value invalid (0-38 dBm)"
[scpi] **ERROR: -97, "Wrong channel selected (0-7)"

Answer 2 · 2019-09-03T14:00:58.000Z

Reopening in case you weren't finished. If you've implemented all the errors you think are important, please close.

Answer 3 · 2019-09-05T11:46:07.000Z

There is also an old one in case of excessive amount of parameters
[scpi] **ERROR: -108, "Parameter not allowed".

I think all error cases are now properly labeled.

Answer 4 · 2019-09-05T11:47:12.000Z

Cool, thanks! Good errors make the user experience so much better.