skortchmark9/reselect-tools

Can't open dev tools window

cshell7 opened this issue · 5 comments

cshell7 commented

Whenever I click on the extension it either takes me to your github page or the page for the extension. I looked for another panel in the devtool window like in your screen shot but didn't see any.

javierfernandes commented

Seems like the button just does that (not sure, I'm just a new user :P)

But you need to access it from the inspect window, there should be a "Reselect" tab

image

I was not seeing it at first, and I have to add setup code for reselect-tools while creating redux store

ReselectTools.getStateWith(() => store.getState())

(as it is in the README)

  • 👍1
skortchmark9 commented

I don't think I set up the notifications properly in this repository. Sorry I didn't respond! @javierfernandes is correct that the button doesn't do anything, and the chrome extension will show up in the dev tools panel only if the reselect bindings have been installed in the app. (Though I think you only need the first part, createSelectorWithDependencies)

I would like to make the icon more useful - it was kinda a rushed job.

beck commented

Landed here too. Found it confusing that clicking the extension just opens the repo.

🤞this tool takes off.

  • 👍1
skortchmark9 commented

Moving all issues from the extension repo to the library repo, as I'm combining them (see #24). Thanks!

skortchmark9 commented

The right thing to do here is to mirror the behavior of the react devtools, and only enable the extension icon when the hooks are installed. See note here

Entrypoint here: https://github.com/skortchmark9/reselect-tools/blob/master/extension/chrome/extension/background.js#L2