slowkow/harmonypy

Reference mapping option

Closed this issue · 2 comments

dhoanghiep commented

Hi,

when reviewing run_harmony(), I found that reference_values is available as a keyword argument. However, reference_values is not referenced anywhere in the function and also does not appear in the Harmony class. I wonder if this feature of reference mapping was implemented in harmonypy.

Thank you

slowkow commented

No, reference_values is not used in the current version of harmonypy. Interested readers should study the R source code to understand this option.

  • 👍1
slowkow commented

Pull requests are welcome. Feel free to open another issue if you have more questions.