[Accepted] Revise SDL 0267 Main Menu UI Updates
Closed this issue · 5 comments
Hello SDL community,
The review of "Revise SDL 0267 Main Menu UI Updates" begins now and continues through January 19, 2021.
This will be a review of proposed revisions to a previously accepted but not yet implemented proposal, SDL 0267.
The pull request outlining the revisions under review is available here:
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
- Is the problem being addressed significant enough to warrant a change to SDL?
- Does this proposal fit well with the feel and direction of SDL?
- If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
- How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Jordyn Mackool
Program Manager - Livio
jordyn@livio.io
1.In the original proposal, the RPC spec has similar parameter additions,
but in this revision, since it is only for HMI_API, we think that the parameter implementation will be different between MOBILE and HMI.
Isn't this a problem?
1\. In the HMI API both, AddSubMenu and AddCommand rely on MenuParams for text fields. However, in the Mobile API, AddSubMenu doesn't. This is the current situation since long time, before this proposal existed. This revision aligns better with the current situation of the APIs.
@kshala-ford -san
Thank you for your reply.
1.I understand that this proposal matches the current implementation.
I think there is no problem.
The Steering Committee voted on 2021-01-19 to accept the revisions to this proposal.
Comments have been left on implementation issues to reference revisions: