This document aims to describe common OAuth/Single Sign On/OpenID-related vulnerabilities. Many cross-site interactions are vulnerable to different kinds of leakings and hijackings.
Both hackers and developers can benefit from reading it.
OAuth is a critical functionality. It is responsible for access to sensitive user data, authentication and authorization. Poorly implemented OAuth is a reliable way to take over an account. Unlike XSS, it is easy to exploit, but hard to mitigate for victims (NoScript won't help, JavaScript is not required).
Because of OAuth many startups including Soundcloud, Foursquare, Airbnb, About.me, Bit.ly, Pinterest, Digg, Stumbleupon, Songkick had an account hijacking vulnerability. And a lot of websites are still vulnerable. Our motivation is to make people aware of "Social login" risks, and we encourage you to use OAuth very carefully.
The cheatsheet does not explain how OAuth flows work, please look for it on the official website.
Also known as The Most Common OAuth2 Vulnerability
Provider returns code by redirecting user-agent to SITE/oauth/callback?code=CODE
Now client must send code along with client credentials and redirect_uri to obtain access_token.
If client implementation doesn't use state parameter to mitigate CSRF, we can easily connect our provider account to victim's client account.
It works for clients with social login and ability to add a login option to existing master account (screenshots of pinterest.com below).
Remediation: Before sending user to provider generate a random nonce and save it in cookies or session. When user is back make sure state you received is equal one from cookies.
State fixation bug: It was possible to fixate state in omniauth because of legacy code which utilized user supplied /connect?state=user_supplied instead of generating a random one.
This is another OAuth design issue - sometimes developers want to use state for own purposes. Although you can send both values concatenated state=welcome_landing.random_nonce, but no doubt it looks ugly.
This is a higher level of the first vulnerability. Even when client properly validates state we are able to replace auth cookies on provider with attacker's account: using CSRF on login (VK, Facebook), header injection, cookie forcing or tossing.
Then we just load a GET request triggering connect (/user/auth/facebook in omniauth), Facebook will respond with attacker's user info (uid=attacker's uid) and it will eventually connect attacker's provider account to victim's client account.
Remediation: make sure that adding a new social connection requires a valid csrf_token, so it is not possible to trigger process with CSRF. Ideally, use POST instead of GET.
Facebook refused to fix CSRF on login from their side. This threat is client's business too, but many libraries remain vulnerable. Do not expect providers to give you reliable authentication data.
OAuth documentation makes it clear that providers must check the first redirect_uri is equal redirect_uri client uses to obtain access_token.
We didn't really check this because it looked too hard to get it wrong.
Surprisingly many providers got it wrong: Foursquare (reported), VK (report, in Russian), Github (could be used to leak tokens to private repos), and a lot of "home made" Single Sign Ons.
The attack is straightforward: find a leaking page on client's domain, insert cross domain image or a link to your website, then use this page as redirect_uri.
When your victim will load crafted URL it will send him to leaking_page?code=CODE and victim's user-agent will expose the code in the Referrer header.
Now you can re-use leaked authorization code on the actual redirect_uri to log in in victim account.
Remediation: flexible redirect_uri is a bad practise. But if you need it, store redirect_uri for every code you issue and verify it on access_token creation.
It was a media hype called "cover redirect" but in fact it was known for years. You simply need to find an open redirect on client's domain or its subdomains, send it as redirect_uri and replace response_type with token,signed_request. 302 redirect will preserve #fragment, and attacker's Javascript code will have access to location.hash.
Leaked access_tokens can be used for spam and ruining your privacy. Furthermore, leaked signed_request is even more sensitive data. By finding an open redirect on client you compromise Login with Facebook completely.
Remediation: whitelist only one redirect_uri in app's settings:
###Account hijacking by using access_token issued for attacker's client. Also known as One Token to Rule Them All. This bug is relevant to mobile and client-side apps, because they often use access_token directly supplied by user.
Imagine, user has many "authorization rings" and gives a ring to every new website where he wants to log in. A malicious website admin can use rings of its users to log in other websites the users use.
.png)
Remediation: Before accepting user supplied access_token check if it was issued for your client_id at https://graph.facebook.com/app?fields=id&access_token=TOKEN
(to be continued)
Client credetials are not as important as it sounds. All you can do is using leaking pages to leak auth code, then manually getting an access_token for them (providing leaking redirect_uri instead of actual). Even this threat can be mitigated when providers use static redirect_uri.
Main difference between OAuth2 and 1 is the way you transfer parameters to providers. In the first version you send all parameters to provider and obtain according request_token. Then you navigate user to provider?request_token=TOKEN and after authorization user is redirected back to client/callback?request_token=SAME_TOKEN.
The idea of fixation here is we can trick user into accepting Token1 supplied by us which was issued for us, then re-use Token1 on client's callback.
This is not a severe vulnerability because it is mostly based on phishing. FYI Paypal express checkout has this bug
Many startups have Facebook Connect, and at the same time they are providers too. Being providers, they must redirect users to 3rd party websites, and those are "open redirects" you just cannot fix. It makes this chain possible: Facebook -> Middleware Provider -> Client's token leakage.
To fix this problem Facebook adds #_=_ in the end of callback URLs. Your startup should "kill" fragment to prevent leaking. Redirect this way:
Location: YOUR_CLIENT/callback?code=code#
If you are allowed to set subdirectory here are path traversal tricks:
-
/old/path/../../new/path
-
/old/path/%2e%2e/%2e%2e/new/path
-
/old/path/%252e%252e/%252e%252e/new/path
-
/new/path///../../old/path/
-
/old/path/.%0a./.%0d./new/path (For Rails, because it strips \n\d\0)
code is sent via GET and potentionally will be stored in the logs. Providers must delete it after use or expire in 5 minutes.