soarcn/UndoBar

Compile error with support-v7 22.1

cheeplusplus opened this issue · 7 comments

When I try to compile with the new v7 support library, I get the following error:

Error: Attribute "buttonStyle" has already been defined

I do not get this error with 22.0. I assume this caused by the definition in attrs.xml conflicting with one introduced in the new support library version.

I second this.

@soarcn 👀 on this please.

DDeg commented

Had same issue with buttonStyle attribute. Temporary fall back to 1.4.

well, I guess this is another attribute conflict issue. I don't have stable internet access this week, and will fix this next week

@soarcn What do you think about just prefixing all attributes with something library-specific? It ensures this will never happen again. Because it's not just about things like the support library breaking things but also about not polluting the attribute namespace.

@yarian Yes, that's how I will fix this

@soarcn Awesome. Thanks!

Works well @soarcn, 🙇