soffes/SAMKeychain

Strings file investigation

andyzaharia opened this issue · 2 comments

andyzaharia commented

Hi,

So apparently there is a problem caused by the strings file in cases where the app is actually not using the English language as the default one. In my case I had an app localized only in French and using the SSKeychain framework (with CocoaPods) caused the app to actually have the En localization, which in this case is not really what one will expect.

Besides removing the strings file I wasnt able to come up with a better fix. I'm thinking maybe the strings file must be moved into a new bundle and use the localization from it to avoid overriding the main bundle localizations override...

imaks commented

I've faced a similar issue and provided PR #135 with the fix.

andyzaharia commented

Yep, I ended up doing the exact same thing to actually fix the problem. Thumbs up for creating the Pull Request, I was planning to create one :)