soft-matter/pims

pims.open(list_of_filenames) doesn't work

anntzer opened this issue · 0 comments

... even though that is documented as supported in the docstring of pims.open. This is because the list_of_filenames is passed to glob.glob, which likewise doesn't support lists.

I suspect this has actually never worked, so the easy way out is to just not document that, but given that ImageSequence does support such inputs, I guess the intent is to also support it in pims.open, which can probably also be done by adding something like if not isinstance(sequence, str): return ImageSequence(sequence, **kwargs) at the top of open() (the proposed typecheck is the same as in ImageSequence._get_files).

Edit: I guess that's basically a dupe of #310, let's keep that discussion over there.