gameover stopped
Nicolastriplec opened this issue · 19 comments
Sometimes in the zsdx 1.8 quest, the gameover sequence is stoped randomly (I have to die about 10 times to bring up the bug), (it seams the bug appears when I m pressing directions while the gameover sequence is starting) not sure. I dont know if it is a but in the quest or in the engine, maybe on_animation_finished is not called?
Hey! I can reproduce this bug by pressing 2 directions and space bar (action button) many times (crazy style) while the hero is starting the game's over phase
Hypothesis: on_command_pressed(command) is overwriting on_animation_finished()?
I can't reproduce the bug. When exactly does this happen in the game-over sequence?
It is very hard to reproduce the bug in a consistent way, now I m at work,
this night I ll send you a capture and a full explanation :)
2014-08-07 14:25 GMT+02:00 Christopho notifications@github.com:
I can't reproduce the bug. When exactly does this happen in the game-over
sequence?—
Reply to this email directly or view it on GitHub
#87 (comment).
[image: Imágenes integradas 1]
The game is "paused" at this state (not crashed, only the script dont
revert the pause state).
I downloaded the game again and I started a new game to ensure that the
save is not corrupted. This time I had to dead 7 times. The bug happens
when the curtain sprite ends the close animation. It seams that
on_animation_finished is not called. To obtain the bug I m presing 2
directions (diagonal or so) and repeatedly the space bar (action button)
while the dead animation starts, after every dead without the bug I use
save and continue and I try again. If you have problems even with that
information to reproduce it I can do a video with my hands and the screen.
It is hard to reproduce but it is not a rare bug, my friend found this bug
when he was playing the game on the outside world. I hope you can reproduce
it. Like amateur programer I m very interested in the cause of that error,
I was learning your engine code and I tried to search the error on c++ (it
seamed easy) but I couldnt. I dont have enought skill for that currently :)
2014-08-07 18:33 GMT+02:00 Carles Castillo nicolastriplec@gmail.com:
It is very hard to reproduce the bug in a consistent way, now I m at work,
this night I ll send you a capture and a full explanation :)2014-08-07 14:25 GMT+02:00 Christopho notifications@github.com:
I can't reproduce the bug. When exactly does this happen in the game-over
sequence?
—
Reply to this email directly or view it on GitHub
#87 (comment).
Thanks for the explanation. I don't see the image though.
Don't worry, I have no idea either about the cause of the bug in the C++ code for now :P
Can you see it now?
2014-08-08 8:37 GMT+02:00 Christopho notifications@github.com:
Thanks for the explanation. I don't see the image though.
Don't worry, I have no idea either about the cause of the bug in the C++
code for now :P—
Reply to this email directly or view it on GitHub
#87 (comment).
Hei Christopho, Could you see the image? I forgot to say that I and my
friend was using windows. Could you reproduce it? thanks!
2014-08-08 9:20 GMT+02:00 Carles Castillo nicolastriplec@gmail.com:
Can you see it now?
2014-08-08 8:37 GMT+02:00 Christopho notifications@github.com:
Thanks for the explanation. I don't see the image though.
Don't worry, I have no idea either about the cause of the bug in the C++
code for now :P—
Reply to this email directly or view it on GitHub
#87 (comment).
No, I still don't see any image here.
Is the file named cortina.png atatched here, :S
2014-08-16 0:05 GMT+02:00 Christopho notifications@github.com:
No, I still don't see any image here.
—
Reply to this email directly or view it on GitHub
#87 (comment).
I think you should add the image by replying on #87, not by replying by e-mail.
U.U so sorry I m a noob!
Thanks for the picture. I still cannot reproduce the bug.
Ok no problem, I m going to make a video for you with an input capture :)
@Nicolastriplec is it this bug? http://youtu.be/RJy4wIIfAiU?t=6m52s
OU yea! it is!
2014-09-10 20:46 GMT+02:00 Christopho notifications@github.com:
@Nicolastriplec https://github.com/Nicolastriplec is it this bug?
http://youtu.be/RJy4wIIfAiU?t=6m52s—
Reply to this email directly or view it on GitHub
#87 (comment).
in spite of it seams in the video the bug is not related with the fairy animation, I m not really sure what cause this bug :S, maybe it is not the key event... I must to investigate more
sprite:on_animation_finished() not called might also explain solarus-games/zelda-roth-se#15
@Nicolastriplec I still cannot reproduce the bug. Do you still want to help as a C++ developer? We need to check if sprite:on_animation_finished() is really not called and to understand why. It is supposed to be called by Sprite::update() (Sprite.cpp:658).
This issue is now fixed thanks to the workaround proposed by @Nicolastriplec.
There is still an unresolved problem in the engine with sprite:on_animation_finished(), it is tracked in solarus-games/solarus#799