sonata-project/SonataNewsBundle

Fix deprecated settings method on block service

soullivaneuh opened this issue · 6 comments

soullivaneuh commented

To be done when sonata-project/SonataBlockBundle#204 will be merged.

sagikazarmark commented

It is done 😉

soullivaneuh commented

@sagikazarmark @OskarStark Nope.

See this as example:

SonataNewsBundle/Block/RecentCommentsBlockService.php

Line 110 in 68a5a23

public function setDefaultSettings(OptionsResolverInterface $resolver)

But feel free to fix it on PR if you're hurry. ;-)

sagikazarmark commented

Ah, sorry. I just noticed the PR is merged.

OskarStark commented

me too... sorry 😄

sagikazarmark commented

PR pushed