sorah/acmesmith

Incompatible with acme-client 0.3.2-0.3.6

wjordan opened this issue · 2 comments

wjordan commented

A breaking change in unixcharles/acme-client#66 (published to RubyGems in v0.3.2) caused acmesmith to fail with uninitialized constant Acme (NameError) because this library uses require 'acme/client'. This change was reverted in unixcharles/acme-client#83 (not yet published to RubyGems), so future versions should work again. However, this means that all versions of acmesmith are broken when used with acme-client 0.3.2 through 0.3.6.

Possible fixes for future release of acmesmith:

  • Change require acme/client to require acme-client
  • Pin acme-client dependency to ['< 0.3.2'], ['> 0.3.6'] to avoid the incompatible versions
sorah commented

thank you for letting me know, I'll check then fix later

On Tue, Jul 19, 2016, 5:59 PM Will Jordan notifications@github.com wrote:

A breaking change in unixcharles/acme-client#66
unixcharles/acme-client#66 (published to
RubyGems in v0.3.2) caused acmesmith to fail with uninitialized constant
Acme (NameError) because this library uses require 'acme/client'. This
change was reverted in unixcharles/acme-client#83
unixcharles/acme-client#83 (not yet published
to RubyGems), so future versions should work again. However, this means
that all versions of acmesmith are broken when used with acme-client
0.3.2 through 0.3.6.

Possible fixes for future release of acmesmith:

  • Change require acme/client to require acme-client
  • Pin acme-client dependency to ['< 0.3.2'], ['> 0.3.6'] to avoid the
    incompatible versions

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8, or mute the thread
https://github.com/notifications/unsubscribe-auth/AABzAFScRq5of8jlP3pEF2V4uc_enEJbks5qXXMDgaJpZM4JQUyB
.

sorah commented

Released v0.4.1 which now use acme-client to require.

  • 🎉1