SAMD_21_Dev Variant.cpp RX led pin definition mistake
aaitken203 opened this issue · 0 comments
aaitken203 commented
Im not too up on how the board variants system works but I think I have found an error in the definintion to the RX_LED pin.
in Variant.cpp the pin for RX is correctly listed as PB03 in the comment section:
` * | | LEDs | | |
- +------------+------------------+--------+-----------------+--------------------------------------------------------------------------------------------------------
- | 25 | | PB03 | RX |
- | 26 | | PA27 | TX |
- +------------+------------------+--------+-----------------+-----------------`
however the code definition shows
// 25..26 - RX/TX LEDS (PB03/PA27) // -------------------- { PORTA, 31, PIO_OUTPUT, PIN_ATTR_DIGITAL, No_ADC_Channel, NOT_ON_PWM, NOT_ON_TIMER, EXTERNAL_INT_NONE }, // used as output only { PORTA, 27, PIO_OUTPUT, PIN_ATTR_DIGITAL, No_ADC_Channel, NOT_ON_PWM, NOT_ON_TIMER, EXTERNAL_INT_NONE }, // used as output only
which lists pin 25 (RX LED) as PA31 which is actually SWDIO.