Diff display problem when text is an input field for Black Duck

Question

Diff display problem when text is an input field for Black Duck

stephenkilbaneadi opened this issue 4 years ago · 10 comments

This browser extension is fantastic, and I'm using it a lot - thank you!

One context I'm using it in is to check the license texts in Black Duck. Black Duck displays each license on a form where attributes can be edited - including the license text itself. This means that the selected text is in a multi-line text input field. The search works okay, but when the diff is displayed, matching text is displayed as plain black-on-black (or something similar - nothing's readable, anyway). Where there are differences, they appear as normal, amid the sea of black. If I compare the same text displayed normally on a page - e.g. spdx.org - the diff shows up perfectly. I see the same problem for both Chrome and Firefox.

Answer 1 · 2021-02-26T11:19:13.000Z

Thanks. Can you post a screenshot? We have a default color scheme which may be breaking in Blackduck. I only have access to Protex so I may not be able to test it myself.

Answer 2 · 2021-02-26T11:41:39.000Z

As seen when comparing the MIT text.

Answer 3 · 2021-02-27T01:45:14.000Z

Thanks. I just confirmed this isn't something I can see in Protex as it was changed in Black Duck. Can you provide the html for the form? You can save the page in chrome as HTML only. I don't know what BlackDuck is embedding in the page so you may want to scrub the html before you provide it.

Answer 4 · 2021-03-01T12:09:38.000Z

Any chance I could mail it to you directly, rather than attaching it here. Just in case I'm missing something in the HTML that should be scrubbed?

Answer 5 · 2021-03-01T23:17:36.000Z

Yes. Same name on gmail.

Answer 6 · 2021-03-02T01:31:30.000Z

Thinking about this more, I'm thinking the solution may be to allow the results to go to a new tab. Any thoughts on that?

Answer 7 · 2021-03-02T08:44:50.000Z

That would work for me. From: Alan Tse <notifications@github.com> Sent: 02 March 2021 01:32 To: spdx/spdx-license-diff <spdx-license-diff@noreply.github.com> Cc: Kilbane, Stephen <Stephen.Kilbane@analog.com>; Author <author@noreply.github.com> Subject: Re: [spdx/spdx-license-diff] Diff display problem when text is an input field for Black Duck (#79) [External] Thinking about this more, I'm thinking the solution may be to allow the results to go to a new tab. Any thoughts on that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/spdx/spdx-license-diff/issues/79*issuecomment-788497569__;Iw!!A3Ni8CS0y2Y!quXMomUmX0DuTmAAFkGehTkQWdvZ1A2sxBcTq-bBGch3-rW5mmGk69AoQcXTk_iZAXoQ$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMPDLVQJ7IKHA67YDXASSZTTBQ5YBANCNFSM4YIFGSEA__;!!A3Ni8CS0y2Y!quXMomUmX0DuTmAAFkGehTkQWdvZ1A2sxBcTq-bBGch3-rW5mmGk69AoQcXTk_2jcKF3$>.

Answer 8 · 2021-03-03T05:34:10.000Z

🎉 This issue has been resolved in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Answer 9 · 2021-03-03T18:53:12.000Z

As a note, the feature is in the top right of the diff window now. Let me know if it doesn't work.

Answer 10 · 2021-03-04T09:08:38.000Z

Works well on Chrome – yay! I see problems on Firefox, though (86.0), using Black Duck and spdx.org/licenses as test sites. * The placement of the diff window seems to be arbitrary on the tab, and sometimes isn't visible at all. (I see this on Black Duck, not on spdx.org); * The new diff tab opens, but doesn't display anything. If I leave the new tab open, click on the expand in the diff window to open a second diff tab, the second diff tab is empty, but now the first diff tab has the right contents. (I see this on both Black Duck and spdx.org). The Firefox problems don't happen every time, but pretty frequently. steve From: Alan Tse <notifications@github.com> Sent: 03 March 2021 18:53 To: spdx/spdx-license-diff <spdx-license-diff@noreply.github.com> Cc: Kilbane, Stephen <Stephen.Kilbane@analog.com>; Author <author@noreply.github.com> Subject: Re: [spdx/spdx-license-diff] Diff display problem when text is an input field for Black Duck (#79) [External] As a note, the feature is in the top right of the diff window now. Let me know if it doesn't work. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/spdx/spdx-license-diff/issues/79*issuecomment-789974019__;Iw!!A3Ni8CS0y2Y!vtRw1TJLeGsh9b6UI5ARmlfHrZhKsq9vcn1WG0XCDAt3jxTZonDDRAUIlODSHmeO8R7E$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMPDLVSVNN7MFXNJLA4DRT3TB2ASRANCNFSM4YIFGSEA__;!!A3Ni8CS0y2Y!vtRw1TJLeGsh9b6UI5ARmlfHrZhKsq9vcn1WG0XCDAt3jxTZonDDRAUIlODSHh4BozhO$>.